feat(input): global shortcuts → shared keyboard-events saga#507
Draft
rulkens wants to merge 7 commits into
Draft
feat(input): global shortcuts → shared keyboard-events saga#507rulkens wants to merge 7 commits into
rulkens wants to merge 7 commits into
Conversation
Design for promoting useKeyboardShortcuts + watchTourKeyboardSaga to one declarative KEYBOARD_SHORTCUTS map + a shared always-on watchKeyboardEventsSaga, with the l dev key becoming a logCameraState command action. Includes the Ground preparation section (createKeyboardListener reshape + getState-in-context as prep-first). Removes the backlog item (index line + detail file) it picks up. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
7-task TDD plan for the shared keyboard-events saga (prep-first: reshape createKeyboardListener + getState-in-context + tour migration; then stepRate, logCameraState action, KEYBOARD_SHORTCUTS map, watchKeyboardEventsSaga, atomic cutover + deletions, verification). Contract-code only per plan-style.md. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… context Reshape createKeyboardListener onto a declarative KeyboardShortcut[] plus a getState reader: each shortcut owns its keys and preventDefault policy (static or a live-state predicate), and the filter now also guards contentEditable targets. Seed the store's getState into saga context so store-reading seams can resolve predicates inside the DOM tick. Migrate watchTourKeyboardSaga onto the new signature with behaviour identical (three static-preventDefault entries). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Route the 'l' key's engine-imperative camera-state log through a reducer-less command action, so the shortcut map stays uniform. The new camera/logCameraState action mirrors goHome; the reconcile effect bag gains a logCameraState closure delegating to the existing engine helper. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
skymap | c2568c2 | Commit Preview URL Branch Preview URL |
Jul 24 2026, 09:04 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes the app's global keyboard shortcuts from the
useKeyboardShortcutsReact hook (akeydownif-chain) to one declarativeKEYBOARD_SHORTCUTSmap + a shared always-onwatchKeyboardEventsSaga, and folds the tour keys (→/←/Space) onto the same path. One keyboard mechanism, one data table, sagas driving intent.Spec:
docs/superpowers/specs/2026-07-23-keyboard-events-saga-design.md. Plan:docs/superpowers/plans/2026-07-23-keyboard-events-saga.md.Executing via subagent-driven development. Draft — landing task-by-task with per-task review; will mark ready after the full-branch review +
/feature-done.Progress:
createKeyboardListener+getStatein saga context + tour-saga migrationstepRateutillogCameraStatecommand action +ReconcileEffectswireKEYBOARD_SHORTCUTSmap +SHORTCUTS_BY_KEYwatchKeyboardEventsSaga(+logCameraStatearm)🤖 Generated with Claude Code