feat(editor): expression node visual distinction#24
Open
albertgwo wants to merge 2 commits intofeat/engine-pr0c-schema-additionsfrom
Open
feat(editor): expression node visual distinction#24albertgwo wants to merge 2 commits intofeat/engine-pr0c-schema-additionsfrom
albertgwo wants to merge 2 commits intofeat/engine-pr0c-schema-additionsfrom
Conversation
- Action nodes now show mode-specific icons: Calculator for transform (expressions), Table for decision-table (rules), Zap for handler - Subtitle text below the node label indicates the action mode - Data classification badges (PII/shield, financial/landmark, credentials/key, internal/eye) appear on nodes and lane headers - Inherited classifications (from lane) render at 50% opacity; explicit classifications at 100% - New design tokens for badge colors (--fp-badge-pii, etc.) - All node types pass data_class through to NodeShell
- Unit tests for getActionMode/getActionModeInfo utility - NodeShell tests for action mode icons (Calculator, Table, Zap) - NodeShell tests for subtitle rendering - NodeShell tests for data classification badges (explicit vs inherited) - LaneHeader tests for data classification badge rendering
![baz-reviewer[bot]](https://avatars.githubusercontent.com/in/933528?s=60&v=4){kind=small}
Comment on lines
+1
to
+12
| import type { ComponentType } from 'react' | ||
| import { ShieldBadgeIcon, LandmarkBadgeIcon, KeyBadgeIcon, EyeBadgeIcon } from './icons' | ||
|
|
||
| export type DataClass = 'pii' | 'financial' | 'credentials' | 'internal' | ||
|
|
||
| interface BadgeDef { | ||
| icon: ComponentType<{ size?: number; className?: string }> | ||
| colorVar: string | ||
| label: string | ||
| } | ||
|
|
||
| const BADGE_MAP: Record<DataClass, BadgeDef> = { |
There was a problem hiding this comment.
packages/editor was modified but no .changeset/*.md was added — should we add a .changeset file documenting the @ruminaider/flowprint-editor change?
Finding type: AI Coding Guidelines | Severity: 🟠 Medium
Want Baz to fix this for you? Activate Fixer
Other fix methods
Prompt for AI Agents:
In packages/editor/src/components/DataClassBadges.tsx around lines 1-65, the new
DataClassBadges component was added but no .changeset was created. Add a new
.changeset/<describe-editor-change>.md file that documents the change for the
@ruminaider/flowprint-editor package (brief title and a short description that the
DataClassBadges component was added/updated), and specify the package release bump
(e.g., patch) in the changeset frontmatter. Ensure the changeset filename is unique,
include the package name exactly, and save the file so the editor package will be
included in the next release.
Heads up!
Your free trial ends tomorrow.
To keep getting your PRs reviewed by Baz, update your team's subscription
Deploying flowprint with
|
| Latest commit: |
33832ee
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4387ee53.flowprint.pages.dev |
| Branch Preview URL: | https://feat-engine-pr12-editor-visu.flowprint.pages.dev |
Contributor
Author
Code Review FindingsImportant (80-89 confidence)1. Missing changeset file (85)
2.
Positive notes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
Dependency
Base: `feat/engine-pr0c-schema-additions` (only needs schema additions)
PR 16 of 16 in the execution engine implementation.
Test plan
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Introduce
getActionModeInfoand feed its icon/subtitle metadata through the action node specs intoNodeShellso expression and decision-table nodes show distinct cues in the editor. AddDataClassBadgesthroughout lane headers and nodes plus matching tokens/styles so explicit and inherited data classifications surface as consistent badges.DataClassBadgesin lane headers and nodes, backed by new colors/tokens and tests so the editor consistently surfaces badge states.Modified files (15)
Latest Contributors(1)
ActionModeinfo and feeding icons/subtitles through node specs intoNodeShellso expression nodes display distinctive cues.Modified files (5)
Latest Contributors(1)