Handle rpCode '7' (no data) as empty result instead of error#44
Open
olivier-babelcast wants to merge 1 commit intorundef:mainfrom
Open
Handle rpCode '7' (no data) as empty result instead of error#44olivier-babelcast wants to merge 1 commit intorundef:mainfrom
olivier-babelcast wants to merge 1 commit intorundef:mainfrom
Conversation
Rithmic returns rpCode=['7', 'no data'] when a query has no results (e.g., order history for an account with no trades). This is not an error condition - treat it as an empty result and log at debug level instead of raising RithmicErrorResponse. Fixes all three code paths: _send_and_recv_immediate, _send_and_recv, and _process_response (request manager flow).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rithmic returns rpCode=['7', 'no data'] when a query has no results (e.g., order history for an account with no trades). This is not an error condition - treat it as an empty result and log at debug level instead of raising RithmicErrorResponse.
Fixes all three code paths: _send_and_recv_immediate, _send_and_recv, and _process_response (request manager flow).