Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What breaks
Cloning the repo on Windows or Linux and running
npm cifails right away, duringpostinstall:`Error: Cannot find module 'extract-zip'
Require stack:
…\errand\scripts\ensure-electron.mjs`
The install script uses two packages that aren't declared in
package.json:extract-zip— used to arrive as part of Electron itself, but Electron 44 stopped shipping it internally, so on a fresh install it's simply not there anymore.@electron/get— still works today, but only because npm happens to hoist it out of Electron's own dependencies. One resolver change and it breaks the same way.There's also one test that fails on Windows:
appBranding.test.tsexpects forward-slash paths, butstorageDirectorybuilds paths withpath.join, which produces backslashes on Windows.Why you've never seen it
On macOS the script extracts Electron with
ditto, so theextract-zipline never runs and macOS paths use forward slashes anyway. Since CI runs onmacos-15only, both problems are invisible there. They only show up for someone cloning on Windows or Linux which is how I found them.The fix
devDependencies(@electron/get@^5.1.0, which dedupes with Electron's own copy, andextract-zip@^2.0.1). Lockfile updated.appBranding.test.tswithjoin(...)/resolve(...)instead of hardcoded slashes, same pattern as the test's own third assertion already uses. What the test checks hasn't changed.Verified on Windows 11 (Node 24, npm 11)
node_modules, rannpm cifrom scratch installs cleanly, Electron extracts.npm run typecheck,npm run lint,npm test(179/179), andnpm run buildall pass.One small thing I noticed
npm run test:uipoints at a vitest project (--project renderer) that isn't defined invitest.config.ts, so it fails on every platform. Hence I'm happy to fix in a follow-up if you'd like.Thanks for open-sourcing Errand, the codebase was easy to find my way around, and it runs nicely on Windows in dev mode.