Fix explicit proof version zero resolution - #1164
Open
DicksonWu654 wants to merge 1 commit into
Open
Conversation
DicksonWu654
marked this pull request as ready for review
September 1, 2026 02:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0inFoundry.resolve_proof_version.Problem
The resolver used a truthiness check for
user_specified_version. Because the parser represents version0as integer0, an explicit request for version0skipped the user-specified branch and fell through to latest-version selection. With later proof versions present, Kontrol could therefore select a different proof than requested.Fix
Use an explicit
Nonecheck so version0follows the same validation and selection path as every other requested version. Existing latest-version behavior remains unchanged when no version is supplied.Regression test
The unit test covers:
0returns02returns23Validation
Tests were not run locally under the review constraint, which prohibits executing repository code and tests. Static review of the complete diff and
git diff --checkcompleted successfully.