Skip to content

fix(cheatcodes): preserve non-empty zero bytecode #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DicksonWu654 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(cheatcodes): preserve non-empty zero bytecode #1165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/kontrol/kdist/cheatcodes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1392,7 +1392,7 @@ We don't care about the values because they will be processed in the `custom_ste
rule <k> #setCode ACCTID CODE => .K ... </k>
<account>
<acctID> ACCTID </acctID>
<code> _ => #if #asWord(CODE) ==Int 0 #then .Bytes #else CODE #fi </code>
<code> _ => #if lengthBytes(CODE) ==Int 0 #then .Bytes #else CODE #fi </code>
...
</account>
```
Expand Down
1 change: 1 addition & 0 deletions src/tests/integration/test-data/foundry-prove-all
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
AccountParamsTest.testDealConcrete()
AccountParamsTest.testDealSymbolic(uint256)
AccountParamsTest.testEtchConcrete()
AccountParamsTest.testEtchEmptyAndZero()
AccountParamsTest.testEtchSymbolic(bytes)
AccountParamsTest.testFail_GetNonce_false()
AccountParamsTest.testFail_GetNonce_true()
Expand Down
15 changes: 15 additions & 0 deletions src/tests/integration/test-data/foundry/test/AccountParamsTest.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,21 @@ contract AccountParamsTest is Test {
assertEq(address(124).code, code);
}

function testEtchEmptyAndZero() public {
address emptyAddress = address(124);
address zeroAddress = address(125);
bytes memory emptyCode = bytes("");
bytes memory zeroCode = hex"00";

vm.etch(emptyAddress, emptyCode);
vm.etch(zeroAddress, zeroCode);

assertEq(emptyAddress.code, emptyCode);
assertEq(emptyAddress.code.length, 0);
assertEq(zeroAddress.code, zeroCode);
assertEq(zeroAddress.code.length, 1);
}

function testEtchSymbolic(bytes calldata code) public {
vm.etch(address(124), code);
assertEq(address(124).code, code);
Expand Down