Update devcontainer configuration and Dockerfile for platform compatibility#550
Update devcontainer configuration and Dockerfile for platform compatibility#550answersamir wants to merge 1 commit intorunwhen-contrib:mainfrom
Conversation
…bility; enhance .gitignore to include devpod files.
There was a problem hiding this comment.
Pull Request Overview
This PR updates the development container configuration to ensure compatibility across different platforms by explicitly specifying the linux/amd64 platform. The changes address potential issues with running the devcontainer on different CPU architectures.
- Adds explicit platform specification to the Dockerfile's FROM instruction
- Updates devcontainer configuration to pass platform arguments during build
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Dockerfile | Adds --platform=linux/amd64 flag to the FROM instruction for explicit platform targeting |
| .devcontainer.json | Includes build arguments to specify platform during container build |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| "dockerfile": "Dockerfile", | ||
| "args": { | ||
| "platform": "linux/amd64" | ||
| } |
There was a problem hiding this comment.
The platform argument in devcontainer.json is redundant since the platform is already specified in the Dockerfile's FROM instruction. Docker build args for platform are typically not needed when --platform is used in FROM.
| } | |
| } | |
enhance .gitignore to include devpod files.