Update tags in various runbooks to include 'data:config' and 'data:logs-regexp' for enhanced categorization and clarity in resource management tasks.#621
Conversation
…gs-regexp' for enhanced categorization and clarity in resource management tasks.
…ag for improved categorization of SQL-related checks.
- Modified storage account names in the Azure cost optimization README for consistency. - Updated GCP project references in runbooks to use a placeholder for improved flexibility. - Refined error handling in GCP Vertex Model Garden health checks to ensure required variables are set, enhancing robustness.
- Introduced `normalize_kubernetes_binary` and `_is_missing_or_placeholder` functions in `cli_utils.py` to ensure consistent handling of Kubernetes CLI binaries, defaulting to "kubectl" when unset or set to placeholders. - Updated `CLI.py` to utilize the new normalization function for the `KUBERNETES_DISTRIBUTION_BINARY` environment variable. - Added `_normalize_k8s_binary` function in `k8s_helper.py` for similar functionality, enhancing robustness in cluster connectivity checks.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| Sync Container Images into Azure Container Registry `${ACR_REGISTRY}` | ||
| [Documentation] Synchronizes the latest container images into an ACR repository | ||
| [Tags] azure acr registry runwhen | ||
| [Tags] azure acr registry runwhen data:config |
There was a problem hiding this comment.
Operational sync task incorrectly tagged as data collection
Low Severity
The Sync Container Images into Azure Container Registry task is tagged with data:config, but it's an operational task that modifies state by synchronizing/pushing container images into ACR. The PR's own tagging rules state that operational tasks which modify state (rather than collecting data) are excluded from data tagging. This task's documentation explicitly says it "Synchronizes the latest container images into an ACR repository," which is a write operation, not a data collection task.
…tes to default to "kubectl" - Modified the `KUBERNETES_DISTRIBUTION_BINARY` environment variable in various taskset YAML templates to use a default value of "kubectl" when not explicitly set, enhancing consistency and robustness in Kubernetes CLI usage across the application.
…gs-regexp' for enhanced categorization and clarity in resource management tasks. (runwhen-contrib#621) * Update tags in various runbooks to include 'data:config' and 'data:logs-regexp' for enhanced categorization and clarity in resource management tasks. * Update PostgreSQL health check runbooks to include 'data:sql-query' tag for improved categorization of SQL-related checks. * Update README and runbook files to enhance clarity and configurability - Modified storage account names in the Azure cost optimization README for consistency. - Updated GCP project references in runbooks to use a placeholder for improved flexibility. - Refined error handling in GCP Vertex Model Garden health checks to ensure required variables are set, enhancing robustness. * Add Kubernetes CLI normalization functions to improve default handling - Introduced `normalize_kubernetes_binary` and `_is_missing_or_placeholder` functions in `cli_utils.py` to ensure consistent handling of Kubernetes CLI binaries, defaulting to "kubectl" when unset or set to placeholders. - Updated `CLI.py` to utilize the new normalization function for the `KUBERNETES_DISTRIBUTION_BINARY` environment variable. - Added `_normalize_k8s_binary` function in `k8s_helper.py` for similar functionality, enhancing robustness in cluster connectivity checks. * Update Kubernetes distribution binary handling across multiple templates to default to "kubectl" - Modified the `KUBERNETES_DISTRIBUTION_BINARY` environment variable in various taskset YAML templates to use a default value of "kubectl" when not explicitly set, enhancing consistency and robustness in Kubernetes CLI usage across the application.


All data tags have been added across all codebundles. Here's a summary of what was done:
Summary
422 data tags were added across 106 robot files in all codebundles:
data:configdata:logs-regexpdata:logs-bulkdata:logs-stacktraceTag Assignment Logic
data:config- Tasks that collect configuration state, resource health status, metrics, describe output, cluster/service configurations, security settings, cost analysis, etc.data:logs-regexp- Tasks that fetch logs with filtering (error patterns, severity filters, diagnostic analysis, grep-based inspection)data:logs-bulk- Tasks that fetch general logs with minimal filtering (tail logs, activity logs, raw log dumps, invocation logs)data:logs-stacktrace- Tasks specifically targeting stacktrace/traceback extraction from logsExcluded from tagging
gh-actions-health/sli.robot- these calculate scores without adding raw dataNote
Medium Risk
Mostly metadata/tagging changes, but the GMP endpoint change alters which GCP project is queried and could break checks if
${GCP_PROJECT_ID}is unset or incorrect.Overview
Standardizes task categorization across many
runbook.robot/sli.robotfiles by addingdata:config,data:logs-regexp, anddata:logs-bulktags (and similar) to existing tasks for configuration/metrics collection vs log collection.Also fixes
curl-gmp-kong-ingress-inspectionto query GMP using${GCP_PROJECT_ID}instead of a hardcoded project, and updates anazure-storage-cost-optimizationREADME example table accordingly.Written by Cursor Bugbot for commit b5b8224. This will update automatically on new commits. Configure here.