Refactor VapourSynthDecoder to allow access to any output node - #18
Open
BoatsMcGee wants to merge 2 commits into
Open
Refactor VapourSynthDecoder to allow access to any output node#18BoatsMcGee wants to merge 2 commits into
BoatsMcGee wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a public (not
pub(crate)) method toVapoursynthDecoderto get a VideoNode at the specified index and optionally apply a node modifier. This requires the caller to know which indexVapoursynthDecoderwas instantiated with and have access to the registered node modifier, so 2 "getter" functions have been added.The getter functions are the bare minimum to get output nodes exactly like
Decodergets. If Application A passes an already instantiatedDecoderto Application B, Application B has no knowledge of what index or node modifier was used so it cannot retrieve the same (modified) output without changing its own API which could introduce unexpected behavior if there's a mismatch. Theget_outputmethod is just a convenience function that removes a lot of boilerplate without being restrictive.Examples
Before:
After:
PlaneStats:
Quality Comparison: