feat: derive Serialize for Migration if serde is enabled - #395
Merged
Conversation
jxs
approved these changes
Oct 6, 2025
jxs
left a comment
jxs
left a comment
Member
There was a problem hiding this comment.
Hi, sorry for the delay, and thanks for this, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To implement custom drivers it would be useful to also expose the
Migrationstruct asserde:Serializableif the serde feature is enabled.I currently need for a custom driver and it seems like other people implemented workarounds already (not sure if the problem is this one exactly): https://github.com/Protryon/klickhouse/blob/67651affb97dfae07084d852d99ffa652b235929/klickhouse/src/migrate.rs#L13-L66
Migrationand associated types if serde is enabled