Fix: propagate TLS errors, fix changelog link, deduplicate query parsing - #416
Closed
hughdbrown wants to merge 5 commits into
Closed
Fix: propagate TLS errors, fix changelog link, deduplicate query parsing#416hughdbrown wants to merge 5 commits into
hughdbrown wants to merge 5 commits into
Conversation
hughdbrown
commented
Mar 9, 2026
hughdbrown
commented
- Replace .unwrap() on native_tls::TlsConnector::new() with .migration_err() in both with_connection! and with_connection_async! macros to propagate errors instead of panicking
- Fix CHANGELOG.md PR fix unused warnings #403 link URL (was pointing to update MSRV #401)
- Collect URL query params once before struct initialization in TryFrom for Config, avoiding redundant parsing for use_tls and trust_cert fields
- Replace .unwrap() on native_tls::TlsConnector::new() with .migration_err() in both with_connection! and with_connection_async! macros to propagate errors instead of panicking - Fix CHANGELOG.md PR rust-db#403 link URL (was pointing to rust-db#401) - Collect URL query params once before struct initialization in TryFrom<Url> for Config, avoiding redundant parsing for use_tls and trust_cert fields Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
|
Hi, and thanks for this! Can we separate this into multiple PR's? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.