Replace tiberius with mssql (maintained fork with security fixes) - #448
Open
joelparkerhenderson wants to merge 1 commit into
Open
Replace tiberius with mssql (maintained fork with security fixes)#448joelparkerhenderson wants to merge 1 commit into
joelparkerhenderson wants to merge 1 commit into
Conversation
tiberius currently has three unpatched RUSTSEC advisories (RUSTSEC-2026-0098, -0099, -0104) in its rustls-webpki dependency, a fix PR (tiberius-rs/tiberius#419) open since 2026-05-12 with no maintainer response, 11 reachable panic sites from untrusted server input (tiberius-rs/tiberius#424, rust-db#425), and a maintainer handover request (tiberius-rs/tiberius#427) unanswered for 11+ days. This renames the tiberius/tiberius-config Cargo features to mssql/mssql-config and swaps the crate dependency to the mssql fork (https://crates.io/crates/mssql, https://github.com/mssql-rust/mssql-rust), which carries the rustls 0.23 upgrade fixing the three advisories. Verified against the published mssql 1.0.1 crate: cargo check -p refinery-core --features mssql-config cargo check -p refinery-core --features mssql cargo check -p refinery --features mssql-config,toml cargo check -p refinery --tests --features mssql-config,toml cargo check -p refinery_cli --features mssql BREAKING CHANGE: refinery_core::tiberius (public re-export) is now refinery_core::mssql; the tiberius/tiberius-config feature flags are renamed to mssql/mssql-config. refinery is pre-1.0 (0.9.2), so this can ship as a minor version bump. An equally-maintained alternative fork, tiberius-ng (https://github.com/MattJackson/tiberius-ng), also fixes these issues and keeps the tiberius name/API if maintainers prefer that direction instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HmakCYmBF3qUgiW7ctoFJm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #447
Problem
Refinery depends on the Rust crate
tiberiuswhich has security problems and maintenance problems. Specifics below.Solution
There are two recent forks of the crate that provide the security updates and PRs.
mssql(mssql-rust/mssql-rust) — maintained by Joel Henderson (me)tiberius-ng(MattJackson/tiberius-ng) — maintained by Matt JacksonEither fork is fine IMHO. You'll want to test them because they're both quite new. I prefer the name
mssqlbecause I work with Microsoft extensively and I'm working with their security teams; Matt prefers thetiberius-ngname because it's more similar to the original.This PR implements the
mssqldirection as one concrete option — happy to redo it againsttiberius-nginstead, or split it differently, if maintainers prefer.Code change
Breaking change: renames the
tiberius/tiberius-configCargo features tomssql/mssql-config,and the public re-export
refinery_core::tiberiusbecomesrefinery_core::mssql. Anyone matching ontiberius::error::Erroror importingrefinery_core::tiberius::*directly will need to update.refinery is pre-1.0 (0.9.2), so this can ship as a minor version bump under Cargo's semver rules.
13 files, mechanical rename (no logic changes beyond the type/feature names) — see the diff for
the full change. Verified against the published
mssql1.0.1 crate:All pass.
Security specifics
fixes this yet has been open since 2026-05-12 with no maintainer response.
Err. Tracked by the RustSec working group at advisory-db#3148.Drafted with Claude Code; I reviewed and take responsibility for the change.
🤖 Generated with Claude Code
https://claude.ai/code/session_01HmakCYmBF3qUgiW7ctoFJm