Update testing - #225
Open
jonathanpallant wants to merge 3 commits into
Open
Update testing#225jonathanpallant wants to merge 3 commits into
jonathanpallant wants to merge 3 commits into
Conversation
Our binaries have the same name so you cannot do things multi-threaded otherwise one test is overwriting a binary that another test is using.
We want to do more testing with RUSTFLAGS. But changing that environment variable doesn't invalidate anything already compiled. So now we use a unique target directory per variant, and variants set the rustflags. Also adds TEST_VERBOSE env var to enable verbose logging of command lines.
jonathanpallant
marked this pull request as ready for review
September 11, 2026 10:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the testing to ensure every RUSTFLAGS variant gets its own target directory.
Also runs the tests single-threaded to avoid racing on the compiled binaries.