Open
Conversation
reitermarkus
force-pushed
the
queue-features
branch
from
5daf664 to
c9447e9
Compare
Member
|
Have you measured how much compile time this saves? IMO features make sense if they prevent pulling in big dependencies, but in this case they just prevent compiling a few hundred lines of code. In this case the compile time difference is probably negligible, and not worth the dev-experience downgrade due to users having to enable features. |
Member
Author
|
No, I didn't measure compile time. Should we just close #372 then? The only non-optional dependency we have is |
reitermarkus
force-pushed
the
queue-features
branch
from
c9447e9 to
6480e27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #372.