Make the URL for the submodule valid#294
Conversation
CMSIS-SVD repository was moved plus git:// makes the git command hang. [Recent change](NixOS/nixpkgs@5cd869c) in the Rust platform in `NixOS/nixpkgs` prevents a user from packaging a Rust program using crates from this repository to be used as dependencies as it forces their submodules to be checked out, regardless of the `submodule.*.update` setting.
|
Alternative: can we just remove cmsis-svd as a submodule altogether? The only place it is used at is the |
I'm fine with either, but I'll merge this for now and if you would like to make a PR removing it and instead cloning it in the script please go ahead. |
|
Ah, it looks like CI is failing on latest stable Rust due to elided lifetime warnings, stopping this from merging. |
|
Will make a PR to fix the warnings. |
Head branch was pushed to by a user without write access
|
I decided to do it all at once in this PR because I realized that URL I switched to leads to a wrong repository anyway (should have been Script works and generates Rust files in a way it was, I think, intended. But I'm not sure how they should be used, Maybe it's enough for this PR. |
|
Forgot about the rebase, right. I merged master into HEAD, I hope that's also okay.
Interesting, it might be worth looking into but maybe as a separate PR or just by reviving the old one. |
Fork repository that contains svd-parser as well as a broken submodule that causes a Cargo vendor crash in the newer versions of the Nix rust-platform (since nixpkgs @ 5cd869caa4ea1bf1bde71731ecc96b24e1bdcc2d). Upstream variant contains a patch that fixes this (rust-embedded/svd#294) and additional features that do not break chiptool. Nice plus: new fetchCargoVendor supports git dependencies, we do not have to use importCargoLock and manually populate git dependencies' output hashes to source dependencies!
Fork repository that contains svd-parser as well as a broken submodule that causes a Cargo vendor crash in the newer versions of the Nix rust-platform (since nixpkgs @ 5cd869caa4ea1bf1bde71731ecc96b24e1bdcc2d). Upstream variant contains a patch that fixes this (rust-embedded/svd#294) and additional features that do not break chiptool. Nice plus: new fetchCargoVendor supports git dependencies, we do not have to use importCargoLock and manually populate git dependencies' output hashes to source dependencies!
3 participants
CMSIS-SVD repository was moved plus git:// makes the git command hang.
Recent
change in the Rust platform in
NixOS/nixpkgsprevents a user from packaging a Rust program using crates from this repository to be used as dependencies as it forces their submodules to be checked out, regardless of thesubmodule.*.updatesetting.