Clean up use of intrinsics where no longer needed#1093
Open
tgross35 wants to merge 5 commits intorust-lang:mainfrom
Open
Clean up use of intrinsics where no longer needed#1093tgross35 wants to merge 5 commits intorust-lang:mainfrom
tgross35 wants to merge 5 commits intorust-lang:mainfrom
Conversation
tgross35
force-pushed
the
intrinsics-cleanup
branch
7 times, most recently
from
57b7c6c to
b953b0e
Compare
This comment has been minimized.
This comment has been minimized.
These are remnants of historical chkstk implementations that are no longer relevant, so clean up the imports here.
This feature has been stable for a while.
Replace the use of intrinsics with `core::hint::cold_path` which has been unstably available for a while, and is on track to become stable in the next release.
`div!` looks innocuous but is actually unsafe. Replace it with function calls that require us to actually use `unsafe`, and add the precondition notes. These can likely be removed completely in the near future. There is one case in `rem_pio2_large` and one in `exp2` where preconditions aren't as easy to define, but fortunately it seems like we are able to just use regular division there without affecting codegen.
tgross35
force-pushed
the
intrinsics-cleanup
branch
from
b953b0e to
3ff194f
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.