Draft
Conversation
tmvkrpxl0
reviewed
Dec 17, 2025
libm/src/math/fma_wide.rs
Outdated
| @@ -5,11 +5,10 @@ use super::support::{FpResult, IntTy, Round, Status}; | |||
| use super::{CastFrom, CastInto, DFloat, Float, HFloat, MinInt}; | |||
|
|
|||
| // Placeholder so we can have `fmaf16` in the `Float` trait. | |||
There was a problem hiding this comment.
Is it really a placeholder if it (now) has implementation?
Contributor
Author
There was a problem hiding this comment.
Indeed, updated to a doc comment :)
tgross35
force-pushed
the
f16-fma
branch
2 times, most recently
from
34f8f69 to
40f4317
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recreated from rust-lang/libm#419