-
Notifications
You must be signed in to change notification settings - Fork 220
DRAFT/POC: proposal for splitting docs.rs into sub-crates / a workspace #3079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
syphar
wants to merge
46
commits into
rust-lang:main
Choose a base branch
from
syphar:separate-binary-all
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@GuillaumeGomez first design feedback? :) ( when you have time, not time critical ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal how I could imagine dosc.rs split into workspaces. ( please ignore the commit messages :) )
I would love to get your feedback @GuillaumeGomez beforeI spend more time on this. Perhaps better to dig into this locally to get a feeling about the structure.
Compile time wise it's worlds, mostly when you're only working on one sub-crates. In any case you won't ever have to compile gix/crates-index/diff etc when you're just working on the builder or webserver. Also working on the watcher you'll not have to pay compile time for static assets ETag generation.
There is still optimization potential where some libraries could work with less dependencies
what's still to be done here:
cratesfyibinary that acts as the old one.