Conversation
|
The dev guide says to wait for a new nightly for this sort of change but there's a |
That is outdated information; could you link me to where you found that? |
It seems correct for rustfmt (until the PR that turns it into a subtree lands) as that pins the version to a nightly, not commit. |
|
Thanks; I'll see to updating those docs. :) |
|
Thanks for taking care of this. :) |
|
📌 Commit 5b88045 has been approved by |
|
@RalfJung just a heads up, it looks like the last bors job needs manual approval |
|
☀️ Test successful - checks-actions |
|
That's just the PR CI job that needs approval; bors will do its thing on a different branch and |
| @@ -1 +1 @@ | |||
| 506e75cbf8cb5305e49a41326307004ca3976029 | |||
| e1ff91f439bc09f566da211c6449821b4e949279 No newline at end of file | |||
There was a problem hiding this comment.
This file is missing the final newline, causing the ./rustup-toolchain script always changes this file to insert a newline here.
rust-lang/rust#83813 made some changes to SourceMap and RealFileName. Now to get a string from a
rustc_span::FileName, we need to specify if we would like the local filesystem path or remapped path via--remap-path-prefix. There seems to be only one place in miri that requires change.