docs: fix 7 typos and grammar errors in comments and documentation - #121
Closed
Avicennasis wants to merge 2 commits into
Closed
Avicennasis wants to merge 2 commits into
Avicennasis wants to merge 2 commits into
Conversation
teor2345
reviewed
Sep 18, 2026
Member
There was a problem hiding this comment.
If we're going to fix typos, let's fix these ones as well.
These fixes are all correct, but they might not be accepted under the internal documentation typo policy:
https://rustc-dev-guide.rust-lang.org/building/compiler-documenting.html#contributing-documentation
| } | ||
| ``` | ||
| While this can be avoided by going to back to `typenum` and using associated types, this adds a lot of unnecessary bounds and inpacts all of the code dealing with it. | ||
| While this can be avoided by going back to `typenum` and using associated types, this adds a lot of unnecessary bounds and inpacts all of the code dealing with it. |
Member
There was a problem hiding this comment.
Whoops, missed a typo
Suggested change
| While this can be avoided by going back to `typenum` and using associated types, this adds a lot of unnecessary bounds and inpacts all of the code dealing with it. | |
| While this can be avoided by going back to `typenum` and using associated types, this adds a lot of unnecessary bounds and impacts all of the code dealing with it. |
| *a huge thanks to [Andreas Borgen Longva](https://github.com/Andlon) and [Sébastien Crozet](https://github.com/sebcrozet) for the help with figuring this out* | ||
|
|
||
| [nalgebra](https://nalgebra.org/) is a linear algebra library. At the core of that library is a type `struct Matrix<T, R, C, S>` where `T` is the components scalar type, `R` and `C` represents the number of rows and columns and `S` represents the type of the buffer containing the data. | ||
| [nalgebra](https://nalgebra.org/) is a linear algebra library. At the core of that library is a type `struct Matrix<T, R, C, S>` where `T` is the components scalar type, `R` and `C` represent the number of rows and columns and `S` represents the type of the buffer containing the data. |
Member
There was a problem hiding this comment.
Missed this one too
Suggested change
| [nalgebra](https://nalgebra.org/) is a linear algebra library. At the core of that library is a type `struct Matrix<T, R, C, S>` where `T` is the components scalar type, `R` and `C` represent the number of rows and columns and `S` represents the type of the buffer containing the data. | |
| [nalgebra](https://nalgebra.org/) is a linear algebra library. At the core of that library is a type `struct Matrix<T, R, C, S>` where `T` is the components' scalar type, `R` and `C` represent the number of rows and columns and `S` represents the type of the buffer containing the data. |
This comment was marked as low quality.
This comment was marked as low quality.
Does that policy apply to this repo? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix 7 typos and grammar errors across 2 files.
vision/status_quo/nalgebra.mdR` and `C` represents the number` →RandCrepresent the number// For matrices of know size.→// For matrices of known size./// A matrix of statically know size.→/// A matrix of statically known size.backwards compatability concern→backwards compatibility concernby going to back totypenum→ `by going back to `typenumBy adding one trait impl impl for→By adding one trait impl formeetings/2021.02.09-lazy-norm.md* additional weirdness`` →* additional weirdness`Otherwise comments, documentation and message strings only — no functional changes.