refactor: centralize comment generation checks#3330
Merged
emilio merged 1 commit intorust-lang:mainfrom Feb 21, 2026
Merged
Conversation
- Add doc_comment() method to FieldData that checks generate_comments flag - Add doc_comment() method to EnumVariant that checks generate_comments flag - Remove redundant generate_comments checks from field codegen - Remove redundant generate_comments checks from enum variant codegen This makes the code more idiomatic by having types that generate comments handle the flag check themselves, eliminating duplication and centralizing the decision logic.
naoNao89
force-pushed
the
refactor/issue-445-comment-generation
branch
from
b9b425b to
751920e
Compare
emilio
approved these changes
Feb 21, 2026
| return None; | ||
| } | ||
|
|
||
| self.comment |
Contributor
There was a problem hiding this comment.
Could be a bit more concise with:
Some(ctx.options().process_comment(self.comment.as_deref()?))
But this is fine as well of course.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hi, this my first pr which refactor. eliminates duplicate
generate_commentschecks from codegen. types now handle check themselves, centralized decision logic per type, cleaner code.FieldData::doc_comment()andEnumVariant::doc_comment()make it idiomatic.Hope receive feedback
fixes #445