Skip to content

Fix println_empty_string suggestion caused error when there is a , after arg #16201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
relaxcn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix println_empty_string suggestion caused error when there is a , after arg #16201

relaxcn wants to merge 1 commit into from
+188 −2

Conversation

@relaxcn
Copy link
Contributor

@relaxcn relaxcn commented Dec 7, 2025 •
edited by rustbot
Loading

Closes: #16167

changelog: [println_empty_string]: fix suggestion caused error when there is a comma after arg.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 7, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 7, 2025

r? @samueltardieu

rustbot has assigned @samueltardieu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

gauravagerwala added a commit to gauravagerwala/rust-clippy that referenced this pull request Dec 7, 2025
@gauravagerwala
Update design for PR rust-lang#16201: Fix println_empty_string sugg…
767ceef 
…estion caused error when there is a `,` after arg
samueltardieu
samueltardieu requested changes Dec 11, 2025
View reviewed changes
Copy link
Member

@samueltardieu samueltardieu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still fails if there are spaces, newlines, or comments before the comma. The fix should be more robust.

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Dec 11, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 11, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot
Copy link
Collaborator

rustbot commented Dec 16, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@relaxcn
Copy link
Contributor Author

relaxcn commented Dec 16, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samueltardieu samueltardieu samueltardieu requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@samueltardieu samueltardieu

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

println-empty-string chokes on , after arg

3 participants

@relaxcn @rustbot @samueltardieu