Skip to content

Extend assigning_clones to cover to_owned-alike methods - #16909

Open
profetia wants to merge 2 commits into
rust-lang:masterfrom
profetia:issue16517
Open

Extend assigning_clones to cover to_owned-alike methods#16909
profetia wants to merge 2 commits into
rust-lang:masterfrom
profetia:issue16517

Conversation

@profetia

@profetia profetia commented Apr 25, 2026

Copy link
Copy Markdown
Member

Closes #16517

Implemented by reusing the logic from unnecessary_to_owned. r? @ada4a, if you don't mind.

changelog: [assigning_clones] extend to cover to_owned-alike methods

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 25, 2026
@profetia
profetia force-pushed the issue16517 branch 2 times, most recently from 0117551 to 191f947 Compare April 28, 2026 17:12
@github-actions

github-actions Bot commented Apr 28, 2026

Copy link
Copy Markdown

Lintcheck changes for 84adcc2

Lint Added Removed Changed
clippy::assigning_clones 9 0 2

This comment will be updated if you push new changes

@ada4a

ada4a commented May 3, 2026

Copy link
Copy Markdown
Contributor

Sorry @profetia, I can't promise I'll have the energy to look at this in the near future.. but I'll try to get to it

Comment thread clippy_lints/src/assigning_clones.rs Outdated
Comment thread clippy_lints/src/assigning_clones.rs Outdated
Comment thread tests/ui/assigning_clones.stderr Outdated
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels May 4, 2026
@profetia
profetia requested a review from ada4a May 5, 2026 15:19
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels May 5, 2026
@profetia

Copy link
Copy Markdown
Member Author

r? clippy

@rustbot rustbot assigned Centri3 and unassigned ada4a Jun 11, 2026
@rustbot

This comment has been minimized.

@rustbot

rustbot commented Sep 12, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

assigning_clones false negative with str::to_string

4 participants