Skip to content

Move the clippy_ci_panic_test integration into a regular test - #17502

Merged
samueltardieu merged 3 commits into
rust-lang:masterfrom
Jarcho:clippy_ci_panic_test
Sep 2, 2026
Merged

samueltardieu merged 3 commits into
rust-lang:masterfrom
Jarcho:clippy_ci_panic_test

Conversation

@Jarcho

@Jarcho Jarcho commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

This has no reason AFAICT to be implemented as an integration test.

r? flip1995

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 3, 2026
@Jarcho
Jarcho force-pushed the clippy_ci_panic_test branch from 44fd956 to d0103d5 Compare August 3, 2026 20:20

@samueltardieu samueltardieu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not a UI test instead?

#![allow(internal_features)]
#![feature(rustc_attrs)]

#[rustc_delayed_bug_from_inside_query]
fn main() {}
//~^ ICE: delayed bug triggered by #[rustc_delayed_bug_from_inside_query]

View changes since this review

@Jarcho

Jarcho commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

Did not know ui_test supported ICEs.

@Jarcho
Jarcho force-pushed the clippy_ci_panic_test branch 3 times, most recently from 188eb28 to 966e708 Compare August 10, 2026 13:04
@Jarcho
Jarcho force-pushed the clippy_ci_panic_test branch from 966e708 to 398ae52 Compare August 17, 2026 15:15
@rustbot

This comment has been minimized.

@Jarcho
Jarcho force-pushed the clippy_ci_panic_test branch from 398ae52 to cdd9d88 Compare August 25, 2026 15:43
@rustbot

rustbot commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Jarcho
Jarcho force-pushed the clippy_ci_panic_test branch from cdd9d88 to 09c7d6f Compare August 25, 2026 15:50
@Jarcho

Jarcho commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

So it turns out we already had an internal test for this. First two commits move it to a regular test and adapt it so it should run without needing to be reblessed as rustc details change.

@samueltardieu
samueltardieu added this pull request to the merge queue Sep 2, 2026
Merged via the queue into rust-lang:master with commit a11da71 Sep 2, 2026
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants