Fix incorrect rust-buffer-project for remote buffers#582
Merged
psibi merged 1 commit intorust-lang:masterfrom Jan 1, 2026
Merged
Fix incorrect rust-buffer-project for remote buffers#582psibi merged 1 commit intorust-lang:masterfrom
psibi merged 1 commit intorust-lang:masterfrom
Conversation
rust-buffer-project function calls `cargo locate-project`, which returns the local path to the Cargo.toml. This causes `cargo` commands such as `cargo clippy` executed through the rust-mode to fail (because it is looking for a local path instead of remote host path) if the project is on a remote tramp connection. Fix by prepending "root" with remote prefix if `file-remote-p default-directory` is not nil.
psibi
approved these changes
Jan 1, 2026
Member
psibi
left a comment
psibi
left a comment
There was a problem hiding this comment.
LGTM. Since there is an already existing test function named rust-test-compile which exercises this code path, I feel comfortable enough to merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My attempt to solve the issue I created in #581 by checking if the
default-directoryis on a remote path in therust-buffer-projectfunction.