core: fix const ptr::swap_nonoverlapping when there are pointers at odd offsets#134689
Merged
bors merged 1 commit intorust-lang:masterfrom Dec 24, 2024
Merged
core: fix const ptr::swap_nonoverlapping when there are pointers at odd offsets#134689bors merged 1 commit intorust-lang:masterfrom
bors merged 1 commit intorust-lang:masterfrom
Conversation
Collaborator
|
rustbot has assigned @workingjubilee. Use |
Collaborator
|
Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter cc @rust-lang/miri, @rust-lang/wg-const-eval |
71fbca1 to
313c4bc
Compare
This comment has been minimized.
This comment has been minimized.
oli-obk
approved these changes
Dec 23, 2024
Contributor
oli-obk
left a comment
There was a problem hiding this comment.
r=me with output blessed
…dd offsets in the type
313c4bc to
af1c8da
Compare
Member
Author
|
@bors r=oli-obk |
Collaborator
Member
Author
|
Somehow this does not show up in the queue? |
Member
Author
|
@bors r=oli-obk |
Collaborator
|
💡 This pull request was already approved, no need to approve it again.
|
Collaborator
Member
Author
|
@bors rollup |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that the pointer gets swapped correctly even if it is not stored at an aligned offset. This rules out implementations that copy things in a
usizeloop -- so our implementation needs to be adjusted to avoid such a loop when running in const context.Part of #133668