Skip to content

std: small sys refactor #149930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
joboet wants to merge 4 commits into
base: main
Choose a base branch
from
Open

std: small sys refactor #149930

joboet wants to merge 4 commits into from
+139 −177

Conversation

@joboet
Copy link
Member

@joboet joboet commented Dec 12, 2025 •
edited by rustbot
Loading

Part of #117276

The large number of files changed just results from the need to update a lot of imports. Actually this PR only:

  • combines the two definitions of RawOsError in sys::pal into one in sys::io
  • moves FULL_BACKTRACE_DEFAULT from sys::pal to sys::backtrace
  • moves the FromInner/IntoInner/... traits into sys (in preparation for removing sys_common entirely)

@rustbot
Copy link
Collaborator

rustbot commented Dec 12, 2025

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-android Operating system: Android O-apple Operating system: Apple (macOS, iOS, tvOS, visionOS, watchOS) O-fuchsia Operating system: Fuchsia O-hermit Operating System: Hermit O-linux Operating system: Linux O-netbsd Operating system: NetBSD O-redox Operating system: Redox, https://www.redox-os.org/ O-SGX Target: SGX O-solaris Operating system: Solaris O-solid Operating System: SOLID O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface O-wasm Target: WASM (WebAssembly), http://webassembly.org/ O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 12, 2025
@ChrisDenton
Copy link
Member

ChrisDenton commented Dec 13, 2025

lgtm

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 13, 2025

📌 Commit 5d83454 has been approved by ChrisDenton

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 13, 2025
@joboet
Copy link
Member Author

joboet commented Dec 13, 2025

@bors rollup=iffy
(this touches quite a lot of platforms)

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Dec 13, 2025
@JonathanBrouwer
Rollup merge of rust-lang#149930 - joboet:small-sys-refactor, r=Chris…
da82e44 
…Denton

std: small `sys` refactor

Part of rust-lang#117276

The large number of files changed just results from the need to update a lot of imports. Actually this PR only:
* combines the two definitions of `RawOsError` in `sys::pal` into one in `sys::io`
* moves `FULL_BACKTRACE_DEFAULT` from `sys::pal` to `sys::backtrace`
* moves the `FromInner`/`IntoInner`/... traits into `sys` (in preparation for removing `sys_common` entirely)
@JonathanBrouwer JonathanBrouwer mentioned this pull request Dec 13, 2025
Closed
bors added a commit that referenced this pull request Dec 13, 2025
@bors
Auto merge of #149953 - JonathanBrouwer:rollup-7gjplg3, r=JonathanBro…
acae308 
…uwer

Rollup of 5 pull requests

Successful merges:

 - #148755 (Constify `DropGuard::dismiss` and trait impls)
 - #148825 (Add SystemTime::{MIN, MAX})
 - #149894 (Update to mdbook 0.5)
 - #149930 (std: small `sys` refactor)
 - #149949 (Cleanup of attribute parsing errors)

r? `@ghost`
`@rustbot` modify labels: rollup
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Dec 13, 2025

@bors r-
#149953 (comment)

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 13, 2025
@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 13, 2025
@joboet
std: move FromInner etc. to sys
9d94af3 
... and remove the `#[doc(hidden)]` in favour of making them `pub(crate)`.
@joboet joboet force-pushed the small-sys-refactor branch from 5d83454 to a3df118 Compare December 13, 2025 19:48
@joboet
Copy link
Member Author

joboet commented Dec 13, 2025

@bors r=@ChrisDenton

@bors
Copy link
Collaborator

bors commented Dec 13, 2025

📌 Commit a3df118 has been approved by ChrisDenton

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 13, 2025
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Dec 13, 2025

Just for fun
@bors try jobs=dist-various-*

rust-bors bot added a commit that referenced this pull request Dec 13, 2025
@rust-bors
Auto merge of #149930 - joboet:small-sys-refactor, r=<try>
3aaf686 
std: small `sys` refactor

try-job: dist-various-*
@rust-bors

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Dec 13, 2025

💔 Test for 3aaf686 failed: CI. Failed jobs:

@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Dec 13, 2025

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 13, 2025
@joboet joboet force-pushed the small-sys-refactor branch from a3df118 to 2d27400 Compare December 13, 2025 22:00
@joboet
Copy link
Member Author

joboet commented Dec 13, 2025

@bors try jobs=dist-various-*

rust-bors bot added a commit that referenced this pull request Dec 13, 2025
@rust-bors
Auto merge of #149930 - joboet:small-sys-refactor, r=<try>
ee1bc49 
std: small `sys` refactor

try-job: dist-various-*
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Dec 13, 2025

☀️ Try build successful (CI)
Build commit: ee1bc49 (ee1bc493a89cee2bf25e8b346659d23da7128dbd, parent: 430d8297c712ca7e8a4866d7ddccf1b71ba5d4d3)

@joboet
Copy link
Member Author

joboet commented Dec 13, 2025

@bors r=@ChrisDenton

@bors
Copy link
Collaborator

bors commented Dec 13, 2025

📌 Commit 2d27400 has been approved by ChrisDenton

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ChrisDenton ChrisDenton

Labels

O-android Operating system: Android O-apple Operating system: Apple (macOS, iOS, tvOS, visionOS, watchOS) O-fuchsia Operating system: Fuchsia O-hermit Operating System: Hermit O-linux Operating system: Linux O-netbsd Operating system: NetBSD O-redox Operating system: Redox, https://www.redox-os.org/ O-SGX Target: SGX O-solaris Operating system: Solaris O-solid Operating System: SOLID O-unix Operating system: Unix-like O-wasi Operating system: Wasi, Webassembly System Interface O-wasm Target: WASM (WebAssembly), http://webassembly.org/ O-windows Operating system: Windows S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@joboet @rustbot @ChrisDenton @bors @JonathanBrouwer @rust-log-analyzer