Skip to content

Conversation

@Zalathar
Copy link
Member

I've always found it confusing that this code uses the word “sort” to describe partitioning candidates into buckets, since it isn't sorting them in the usual sense.

This PR therefore renames the relevant methods:

  • sort_candidatespartition_candidates_into_buckets
  • sort_candidatechoose_bucket_for_candidate

In addition, this PR moves those methods into their own buckets module, updates some comments to reflect the renaming, and also makes partition_candidates_into_buckets return a named struct instead of a tuple.

There should be no change to compiler behaviour.

@rustbot
Copy link
Collaborator

rustbot commented Dec 13, 2025

Some changes occurred in match lowering

cc @Nadrieril

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 13, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 13, 2025

r? @saethlin

rustbot has assigned @saethlin.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants