Skip to content

Port lint attributes to attribute parser#152369

Open
Bryntet wants to merge 13 commits intorust-lang:mainfrom
Bryntet:lint_attrs
Open

Port lint attributes to attribute parser#152369
Bryntet wants to merge 13 commits intorust-lang:mainfrom
Bryntet:lint_attrs

Conversation

@Bryntet
Copy link
Contributor

@Bryntet Bryntet commented Feb 9, 2026 •
edited by rustbot
Loading

View all comments

Tracking issue: #131229

Ports #[allow], #[deny], #[expect], #[forbid], and #[warn] to being parsed attrs

I tried my best to make this PR as small as possible, it was difficult. I hope it isn't too difficult to review

r? @JonathanBrouwer
r? @jdonszelmann

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 9, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@JonathanBrouwer JonathanBrouwer mentioned this pull request Feb 9, 2026
Open
9 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbot rustbot added the T-clippy Relevant to the Clippy team. label Feb 22, 2026
@Bryntet Bryntet changed the title lint attrs Port lint attributes to attribute parser Feb 22, 2026
@Bryntet Bryntet marked this pull request as ready for review February 22, 2026 18:57
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 22, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 22, 2026

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

Some changes occurred in compiler/rustc_hir/src/attrs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 22, 2026
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Feb 22, 2026

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Feb 22, 2026
@bors
Auto merge of #152369 - Bryntet:lint_attrs, r=<try>
46a7bb3 
Port lint attributes to attribute parser
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Feb 22, 2026
@Bryntet Bryntet force-pushed the lint_attrs branch 2 times, most recently from e70b414 to d9434c9 Compare February 22, 2026 20:19
JonathanBrouwer
JonathanBrouwer reviewed Feb 22, 2026
View reviewed changes
Bryntet added 2 commits March 2, 2026 16:09
@Bryntet
make lint_index not optional in LintExpectationId
40344f6 
also add attr_id to `Stable` variant directly, instead of having to
iterate over all the attrs on the hir_id to find it
@Bryntet
integrate parsed lint attrs into lint level system
57a77c0 
also changes method `parse_limited_all` to take Iterator as an input,
to avoid needing to do expensive allocation
@Bryntet
Copy link
Contributor Author

Bryntet commented Mar 2, 2026

@bors try

@rustbot
Copy link
Collaborator

rustbot commented Mar 2, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Mar 2, 2026
@bors
Auto merge of #152369 - Bryntet:lint_attrs, r=<try>
3442569 
Port lint attributes to attribute parser
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Bryntet
Copy link
Contributor Author

Bryntet commented Mar 2, 2026

@bors try cancel

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 2, 2026

Try build cancelled. Cancelled workflows:

Bryntet added 6 commits March 2, 2026 17:25
@Bryntet
integrate new parsed lint attrs into clippy
26d6e12
@Bryntet
bless tests and tidy
f25b229 
also removes E0452 and splits
`tests/rustdoc-ui/lints/renamed-lint-still-applies` into 2 tests

this is because of delayed warn lint being lost on compiler aborting on
error
@Bryntet
don't parse attributes in pre-expansion lints
4841829 
also buffer any lints coming from pre-expansion, so that they are
emitted with proper lint level
@Bryntet
for integrate parsed lint attrs into lint level system
5a23a1f
@Bryntet
tidy
65eac54
@Bryntet
temporarily revert to using LintDiagnostic
a3578e1
@Bryntet
Copy link
Contributor Author

Bryntet commented Mar 2, 2026

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot pushed a commit that referenced this pull request Mar 2, 2026
@bors
Auto merge of #152369 - Bryntet:lint_attrs, r=<try>
77594c3 
Port lint attributes to attribute parser
@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 2, 2026

☀️ Try build successful (CI)
Build commit: 77594c3 (77594c320e91bebc2c543ff61a19b61521a28365, parent: 8ddf4ef064fb702fed0f3d239ec8d0bac607484e)

@JonathanBrouwer

This comment was marked as outdated.

Sign in to view
@rust-timer

This comment was marked as outdated.

Sign in to view
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 2, 2026
@JonathanBrouwer

This comment was marked as outdated.

Sign in to view
@rust-timer

This comment was marked as outdated.

Sign in to view
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Mar 2, 2026

@rust-timer build 77594c3

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

rust-timer commented Mar 2, 2026

Finished benchmarking commit (77594c3): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)		 0.3% [0.1%, 0.6%] 26
Regressions ❌
(secondary)		 0.4% [0.0%, 0.7%] 45
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.3% [-0.5%, -0.0%] 9
All ❌✅ (primary) 0.3% [0.1%, 0.6%] 26

Max RSS (memory usage)

Results (primary 1.7%, secondary 2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 1.7% [0.5%, 3.3%] 4
Regressions ❌
(secondary)		 3.5% [2.1%, 6.9%] 6
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.2% [-1.2%, -1.2%] 1
All ❌✅ (primary) 1.7% [0.5%, 3.3%] 4

Cycles

Results (secondary 6.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 6.4% [6.4%, 6.4%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 480.113s -> 478.638s (-0.31%)
Artifact size: 396.96 MiB -> 395.09 MiB (-0.47%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JonathanBrouwer JonathanBrouwer JonathanBrouwer left review comments

Assignees

@JonathanBrouwer JonathanBrouwer

@jdonszelmann jdonszelmann

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) perf-regression Performance regression. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Bryntet @rust-log-analyzer @rustbot @JonathanBrouwer @rust-timer @blyxyas @jdonszelmann