tests/ui/asm: add annotations for reference rules#152881
Open
DanielEScherzer wants to merge 1 commit intorust-lang:mainfrom
Open
tests/ui/asm: add annotations for reference rules#152881DanielEScherzer wants to merge 1 commit intorust-lang:mainfrom
DanielEScherzer wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
DanielEScherzer
force-pushed
the
test-references-const-eval
branch
from
0df0c2a to
21c2d39
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
ehuss
reviewed
Feb 24, 2026
| //@ needs-asm-support | ||
| //@ ignore-nvptx64 | ||
| //@ ignore-spirv | ||
| //@ reference: attributes.codegen.naked.unsafe-attribute |
Contributor
There was a problem hiding this comment.
I don't think this really covers attributes.codegen.naked.unsafe-attribute.
I would expect tests for that rule to show:
#[naked] is not allowed, it must be unsafe. (I can't actually find a test for this.)
#[unsafe(naked)] naked_asm should return or diverge (though that may not be possible to test since otherwise it's just UB).
| @@ -1,4 +1,6 @@ | |||
| //@ needs-asm-support | |||
| //@ reference: asm.ts-args.syntax | |||
Contributor
There was a problem hiding this comment.
This could also include asm.syntax since it is generally exercising the parsing rules there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? lang-docs