Open
Conversation
Collaborator
|
Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
rustbot
added
S-waiting-on-review
Member
|
since this is more a compiler related change, I'll reroll from @jhpratt r? compiler |
Member
|
This PR is linked to a GSOC idea/proposal, where I and @jhpratt are mentors, we will both review it. r? Urgau |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
It turns out the CI is failing because I was printing |
CoCo-Japan-pan
force-pushed
the
impl-restriction-parse
branch
from
1ad4b8a to
0345b89
Compare
Urgau
reviewed
Feb 22, 2026
This comment has been minimized.
This comment has been minimized.
CoCo-Japan-pan
force-pushed
the
impl-restriction-parse
branch
from
14453b8 to
13e1685
Compare
Contributor
Author
|
@Urgau Thanks for the feedback! I've addressed all the comments. Ready for another look! |
Urgau
reviewed
Feb 22, 2026
Member
There was a problem hiding this comment.
Look good to me. I will let @jhpratt do the final review.
Member
|
Btw, 17 commits is a bit too much, it would be great if you could squash them to max 2/3 commits. |
fmease
reviewed
Feb 22, 2026
CoCo-Japan-pan
force-pushed
the
impl-restriction-parse
branch
from
7d71945 to
50d182e
Compare
CoCo-Japan-pan
changed the title
impl restriction to ASTimpl restrictions
CoCo-Japan-pan
force-pushed
the
impl-restriction-parse
branch
from
286fff4 to
5c157c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the parsing logic for
implrestrictions (e.g.,pub impl(crate) trait Foo {}) as proposed in RFC 3323.As the first step of the RFC implementation, this PR focuses strictly on the parsing phase. The new syntax is guarded by the
#![feature(impl_restriction)]feature gate.This implementation basically follows the pattern used in #141754.
r? @jhpratt