Allow tidy check in codegen by reddevilmidzy · Pull Request #153166 · rust-lang/rust

reddevilmidzy · 2026-02-27T04:08:47Z

Fixes: #152280
MCP: rust-lang/compiler-team#963

I've separated the commits for easier review.

r? lcnr

Add compiler/rustc_codegen_cranelift/scripts/filter_profile.rs to the ALLOWED list for bins, and add compiler/rustc_codegen_gcc/build_system/src/utils.rs to the unit test exclusion list.

reddevilmidzy · 2026-02-27T04:10:19Z

src/tools/tidy/src/alphabetical.rs

+            // Patch files may include tidy markers unrelated to source ordering.
+            || path.extension() == Some(OsStr::new("patch"))


The .patch was allowed because of this file.

rust/compiler/rustc_codegen_cranelift/patches/0027-sysroot_tests-128bit-atomic-operations.patch

Lines 16 to 20 in 6a979b3

+++ b/coretests/tests/lib.rs

@@ -2,4 +2,3 @@

// tidy-alphabetical-start

-#![cfg_attr(target_has_atomic = "128", feature(integer_atomics))]

#![feature(array_ptr_get)]

reddevilmidzy · 2026-02-27T04:12:22Z

compiler/rustc_codegen_gcc/tools/generate_intrinsics.py

    with open(output_file, "w", encoding="utf8") as out:
        out.write("""// File generated by `rustc_codegen_gcc/tools/generate_intrinsics.py`
 // DO NOT EDIT IT!
+// ignore-tidy-filelength


I added // ignore-tidy-filelength here and also manually added it to compiler/rustc_codegen_gcc/src/intrinsic/archs.rs.

reddevilmidzy · 2026-02-27T04:16:12Z

src/tools/tidy/src/unit_tests.rs

@@ -65,6 +65,7 @@ pub fn check(root_path: &Path, stdlib: bool, tidy_ctx: TidyCtx) {
                || path.ends_with("library/alloc/src/collections/vec_deque/tests.rs")
                || path.ends_with("library/alloc/src/raw_vec/tests.rs")
                || path.ends_with("library/alloc/src/wtf8/tests.rs")
+                || path.ends_with("compiler/rustc_codegen_gcc/build_system/src/utils.rs")


rust/compiler/rustc_codegen_gcc/build_system/src/utils.rs

Lines 426 to 442 in 6a979b3

#[test]

fn test_split_args() {

// Missing `"` at the end.

assert!(split_args("\"tada").is_err());

// Missing `'` at the end.

assert!(split_args("\'tada").is_err());

assert_eq!(

split_args("a \"b\" c"),

Ok(vec!["a".to_string(), "\"b\"".to_string(), "c".to_string()])

);

// Trailing whitespace characters.

assert_eq!(

split_args(" a \"b\" c "),

Ok(vec!["a".to_string(), "\"b\"".to_string(), "c".to_string()])

);

}

Because of this test, should I move the test or allow this?
It felt like a strong unit test, and I didn't see a good place for it, so I allowed it for now.

rustbot · 2026-02-27T06:21:16Z

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

bjorn3 · 2026-02-27T07:28:01Z

Tidy does not run inside the cg_clif and cg_gcc repos, which means whenever we do a sync, there is a fair chance that we did be forced to male changes when tidy complains.

jieyouxu · 2026-02-27T09:46:55Z

Tidy does not run inside the cg_clif and cg_gcc repos, which means whenever we do a sync, there is a fair chance that we did be forced to male changes when tidy complains.

I would suggest not running full tidy against the cg_* subtrees yeah.

Also, doesn't rust-lang/compiler-team#963 only say TODO -> FIXME? Not other tidy checks? I do not think we should be enforcing other tidy rules for the cg_* subtrees.

reddevilmidzy · 2026-02-27T10:56:56Z

Ah, I overinterpreted it — my mistake. Thanks for the clarification. I’ll update it accordingly.

rust-bors · 2026-03-02T16:18:54Z

☔ The latest upstream changes (presumably #153278) made this pull request unmergeable. Please resolve the merge conflicts.

reddevilmidzy added 9 commits February 27, 2026 03:49

Remove codegen backends from tidy skip list

533d0d8

Ignore .patch files in tidy alphabetical check

9501db3

Normalize whitespace, indentation and backticks

cc9b082

Add ignore-tidy-dbg to SIMD examples

cc68328

Add ignore-tidy-linelength

966cbd7

Reorder attribute order

fa8bacf

Update mylib Cargo edition to 2021

6979f59

Modify tidy filter

586ca48

Add compiler/rustc_codegen_cranelift/scripts/filter_profile.rs to the ALLOWED list for bins, and add compiler/rustc_codegen_gcc/build_system/src/utils.rs to the unit test exclusion list.

Replace TODO with FIXME across codegen backends

8af1d2e

reddevilmidzy commented Feb 27, 2026

View reviewed changes

rustbot assigned lcnr Feb 27, 2026

reddevilmidzy marked this pull request as ready for review February 27, 2026 06:21

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 27, 2026

reddevilmidzy marked this pull request as draft February 27, 2026 10:58

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Allow tidy check in codegen#153166

Allow tidy check in codegen#153166
reddevilmidzy wants to merge 9 commits intorust-lang:mainfrom
reddevilmidzy:codegen-tidy

reddevilmidzy commented Feb 27, 2026 •

edited

Loading

Uh oh!

reddevilmidzy Feb 27, 2026

Uh oh!

reddevilmidzy Feb 27, 2026

Uh oh!

reddevilmidzy Feb 27, 2026

Uh oh!

rustbot commented Feb 27, 2026

Uh oh!

bjorn3 commented Feb 27, 2026

Uh oh!

jieyouxu commented Feb 27, 2026 •

edited

Loading

Uh oh!

reddevilmidzy commented Feb 27, 2026

Uh oh!

rust-bors bot commented Mar 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		// Patch files may include tidy markers unrelated to source ordering.
		\|\| path.extension() == Some(OsStr::new("patch"))

	+++ b/coretests/tests/lib.rs
	@@ -2,4 +2,3 @@
	// tidy-alphabetical-start
	-#![cfg_attr(target_has_atomic = "128", feature(integer_atomics))]
	#![feature(array_ptr_get)]

	#[test]
	fn test_split_args() {
	// Missing `"` at the end.
	assert!(split_args("\"tada").is_err());
	// Missing `'` at the end.
	assert!(split_args("\'tada").is_err());

	assert_eq!(
	split_args("a \"b\" c"),
	Ok(vec!["a".to_string(), "\"b\"".to_string(), "c".to_string()])
	);
	// Trailing whitespace characters.
	assert_eq!(
	split_args(" a \"b\" c "),
	Ok(vec!["a".to_string(), "\"b\"".to_string(), "c".to_string()])
	);
	}

Uh oh!

Conversation

reddevilmidzy commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

reddevilmidzy Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

reddevilmidzy Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

reddevilmidzy Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

rustbot commented Feb 27, 2026

Uh oh!

bjorn3 commented Feb 27, 2026

Uh oh!

jieyouxu commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

reddevilmidzy commented Feb 27, 2026

Uh oh!

rust-bors bot commented Mar 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

reddevilmidzy commented Feb 27, 2026 •

edited

Loading

jieyouxu commented Feb 27, 2026 •

edited

Loading