Skip to content

Roll rustfmt reviewers for in-tree rustfmt#153230

Open
jieyouxu wants to merge 1 commit intorust-lang:mainfrom
jieyouxu:rustfmt-reviewers-for-rustfmt
Open

Roll rustfmt reviewers for in-tree rustfmt#153230
jieyouxu wants to merge 1 commit intorust-lang:mainfrom
jieyouxu:rustfmt-reviewers-for-rustfmt

Conversation

@jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented Feb 28, 2026

Noticed in #153229 (comment), where because src/tools/rustfmt has no corresponding [assign.owners] entry, it rolls one of the fallback reviewers (Mark and me) which is needless indirection, since if it rolls to Mark, Mark will have to reroll again.

This can also be

"/src/tools/rustfmt" = ["rustfmt", "rustfmt-contributors"]

which corresponds to https://github.com/orgs/rust-lang/teams/rustfmt and https://github.com/orgs/rust-lang/teams/rustfmt-contributors respectively. I will double-check with triagebot team if we can use review rotation toggles for rust-lang/rust in-tree rustfmt specifically.

Discussion: #t-rustfmt > review queue tracking for rust-lang/rust in-tree rustfmt

Unresolved question

  • Do we want to start everyone off as off-rotation? Or on-rotation? I plan to start conservatively by preserving existing effective status, which is everyone off-rotation.

r? @ytmimi

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 28, 2026
@jieyouxu jieyouxu force-pushed the rustfmt-reviewers-for-rustfmt branch from d8bf9fc to c9763e7 Compare March 1, 2026 08:30
@jieyouxu jieyouxu marked this pull request as ready for review March 1, 2026 08:32
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 1, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 1, 2026

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants