Roll rustfmt reviewers for in-tree rustfmt#153230
Open
jieyouxu wants to merge 1 commit intorust-lang:mainfrom
Open
Roll rustfmt reviewers for in-tree rustfmt#153230jieyouxu wants to merge 1 commit intorust-lang:mainfrom
jieyouxu wants to merge 1 commit intorust-lang:mainfrom
Conversation
d8bf9fc to
c9763e7
Compare
Collaborator
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed in #153229 (comment), where because
src/tools/rustfmthas no corresponding[assign.owners]entry, it rolls one of thefallbackreviewers (Mark and me) which is needless indirection, since if it rolls to Mark, Mark will have to reroll again.This can also be
which corresponds to https://github.com/orgs/rust-lang/teams/rustfmt and https://github.com/orgs/rust-lang/teams/rustfmt-contributors respectively. I will double-check with triagebot team if we can use review rotation toggles for
rust-lang/rustin-treerustfmtspecifically.Discussion: #t-rustfmt > review queue tracking for rust-lang/rust in-tree rustfmt
Unresolved question
r? @ytmimi