constify `TryFrom<Vec>` for array by Lars-Schumann · Pull Request #155616 · rust-lang/rust

Lars-Schumann · 2026-04-21T20:14:29Z

this makes Vec const Destruct along the way.

rustbot · 2026-04-21T20:14:35Z

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 72 candidates
Random selection from 18 candidates

jackh726 · 2026-04-23T19:38:13Z

r? libs-api

Lars-Schumann · 2026-04-24T20:55:26Z

assigned reviewer seems inactive atm
r? rust-lang/wg-const-eval

lcnr · 2026-05-05T15:11:36Z

r? oli

is this blocked on figuring out std constification

lcnr · 2026-05-05T15:11:39Z

r? oli-obk

rustbot · 2026-05-05T15:11:40Z

Failed to set assignee to oli: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

oli-obk · 2026-05-06T09:12:13Z

Huh why does this affect mir-opts?

I think this is fine under std constification, because it tests a very specific use case of a core type like Vec. At minimum we should have const Drop for Vec

Lars-Schumann · 2026-06-11T16:26:35Z

@rustbot ready

oli-obk · 2026-06-12T15:47:18Z

@bors try

constify `TryFrom<Vec>` for array

rust-bors · 2026-06-12T17:55:59Z

☀️ Try build successful (CI)
Build commit: cbee760 (cbee760252c8a6c653c33245ccdf6f9dffb7d7c9, parent: 09a371361240e42b0d69438fd1179efcf212e576)

oli-obk · 2026-06-16T11:16:42Z

@bors r+

rust-bors · 2026-06-16T11:16:45Z

📌 Commit 123d0d1 has been approved by oli-obk

It is now in the queue for this repository.

…-vec, r=oli-obk constify `TryFrom<Vec>` for array Related issues rust-lang#79597, rust-lang#143773, rust-lang#133214 this makes `Vec` `const Destruct` along the way.

…uwer Rollup of 10 pull requests Successful merges: - #155535 (export symbols: support macos/windows(32/64)) - #156538 (Refactor `AliasTy`. `AliasTerm` & `UnevaluatedConst` to use `Alias`) - #156807 (Add `T: PartialEq` bounds to derived `StructuralPartialEq` impls.) - #156950 (Staticlib rename internal symbols) - #157702 (Add expansion info to implied bounds) - #155616 (constify `TryFrom<Vec>` for array) - #156226 (diagnostics: point to coroutine body on higher-ranked auto trait errors) - #157873 (mips: set llvm_args -mno-check-zero-division for all mips targets) - #157953 (fix(rustc_codegen_ssa): Use cg_operand for Freeze check) - #157958 (doc: Document `-Zlint-rust-version`)

…-vec, r=oli-obk constify `TryFrom<Vec>` for array Related issues rust-lang#79597, rust-lang#143773, rust-lang#133214 this makes `Vec` `const Destruct` along the way.

…uwer Rollup of 13 pull requests Successful merges: - #156538 (Refactor `AliasTy`. `AliasTerm` & `UnevaluatedConst` to use `Alias`) - #156807 (Add `T: PartialEq` bounds to derived `StructuralPartialEq` impls.) - #156950 (Staticlib rename internal symbols) - #156983 (Add `io::Read::read_le` and `io::Read::read_be`) - #157306 (tests: codegen-llvm: Expect the new mangling scheme in bpf-abi-indirect-return) - #157702 (Add expansion info to implied bounds) - #155616 (constify `TryFrom<Vec>` for array) - #156226 (diagnostics: point to coroutine body on higher-ranked auto trait errors) - #157870 (std: sys: solid: clamp connect_timeout tv_sec instead of truncating) - #157952 (Configure Renovate for GitHub Actions) - #157953 (fix(rustc_codegen_ssa): Use cg_operand for Freeze check) - #157958 (doc: Document `-Zlint-rust-version`) - #157974 (Rename `errors.rs` file to `diagnostics.rs` (11/N))

@oli-obk

Don't rely on std traits not being const in tests Many of these were dealt with in rust-lang#155616 There are some remaining ones r? @oli-obk

@oli-obk

Don't rely on std traits not being const in tests Many of these were dealt with in rust-lang#155616 There are some remaining ones r? @oli-obk

@oli-obk

Don't rely on std traits not being const in tests Many of these were dealt with in rust-lang#155616 There are some remaining ones r? @oli-obk

@oli-obk

Rollup merge of #161346 - Randl:non-const-tests, r=oli-obk Don't rely on std traits not being const in tests Many of these were dealt with in #155616 There are some remaining ones r? @oli-obk

@oli-obk

Don't rely on std traits not being const in tests Many of these were dealt with in rust-lang/rust#155616 There are some remaining ones r? @oli-obk

rustbot assigned jackh726 Apr 21, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 21, 2026

This comment has been minimized.

Sign in to view

Lars-Schumann marked this pull request as draft April 21, 2026 21:26

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2026

Lars-Schumann force-pushed the const-array-try-from-vec branch from 9c141c1 to f59366f Compare April 21, 2026 21:29

This comment has been minimized.

Sign in to view

Lars-Schumann force-pushed the const-array-try-from-vec branch from f59366f to 8acdb36 Compare April 22, 2026 07:26

Lars-Schumann commented Apr 22, 2026

View reviewed changes

Comment thread library/alloc/src/vec/mod.rs

Lars-Schumann marked this pull request as ready for review April 22, 2026 08:01

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 22, 2026

rustbot added the T-libs-api [DEPRECATED; DO NOT USE] label Apr 23, 2026

rustbot assigned the8472 and unassigned jackh726 Apr 23, 2026

rustbot assigned lcnr and unassigned the8472 Apr 24, 2026

rustbot assigned oli-obk and unassigned lcnr May 5, 2026

oli-obk removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 6, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 11, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Jun 12, 2026

Auto merge of #155616 - Lars-Schumann:const-array-try-from-vec, r=<try>

cbee760

constify `TryFrom<Vec>` for array

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 16, 2026

JonathanBrouwer mentioned this pull request Jun 16, 2026

Rollup of 9 pull requests #157963

Closed

JonathanBrouwer mentioned this pull request Jun 16, 2026

Rollup of 10 pull requests #157975

Closed

This was referenced Jun 16, 2026

Rollup of 12 pull requests #157981

Closed

Rollup of 13 pull requests #157991

Merged

rust-bors Bot merged commit 43fbc54 into rust-lang:main Jun 16, 2026
13 checks passed

rustbot added this to the 1.98.0 milestone Jun 16, 2026

apiraino mentioned this pull request Jun 19, 2026

[ICE]: Found unstable fingerprints for explicit_supertraits_containing_assoc_item #158093

Closed

Randl mentioned this pull request Aug 19, 2026

Don't rely on std traits not being const in tests #161346

Merged

pfugate mentioned this pull request Sep 13, 2026

[Regression 1.98.1] needless_borrows_for_generic_args hangs on Option::filter with a recursive enum rust-lang/rust-clippy#17717

Open

Uh oh!

Uh oh!

Conversation

Lars-Schumann commented Apr 21, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Apr 21, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

jackh726 commented Apr 23, 2026

Uh oh!

Lars-Schumann commented Apr 24, 2026

Uh oh!

lcnr commented May 5, 2026

Uh oh!

lcnr commented May 5, 2026

Uh oh!

rustbot commented May 5, 2026

Uh oh!

oli-obk commented May 6, 2026

Uh oh!

Lars-Schumann commented Jun 11, 2026

Uh oh!

oli-obk commented Jun 12, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Jun 12, 2026

Uh oh!

oli-obk commented Jun 16, 2026

Uh oh!

rust-bors Bot commented Jun 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Lars-Schumann commented Apr 21, 2026 •

edited by rustbot

Loading