Skip to content

windows-gnu: enable native TLS - #159021

Open
mati865 wants to merge 1 commit into
rust-lang:mainfrom
mati865:mingw-native-tls
Open

windows-gnu: enable native TLS#159021
mati865 wants to merge 1 commit into
rust-lang:mainfrom
mati865:mingw-native-tls

Conversation

@mati865

@mati865 mati865 commented Jul 9, 2026

Copy link
Copy Markdown
Member

Since Rust 1.98 we have declared minimal supported versions for the tools like the linker. That means native TLS is supposed to work now as seen in try builds in: #156819
Therefore, this change is very likely to cause issues if somebody still doesn't adhere to the requirements. As such I don't know what form of approval will be required.

Fixes #91659
Fixes #135719

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 9, 2026
@mati865

This comment was marked as resolved.

@rust-bors

This comment was marked as resolved.

@mati865

This comment was marked as resolved.

@rust-bors

This comment was marked as resolved.

@mati865

mati865 commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

@bors try jobs=x86_64-mingw,i686-mingw

@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Jul 9, 2026
windows-gnu: enable native TLS


try-job: *x86_64-mingw*
try-job: *i686-mingw*
@rust-bors

rust-bors Bot commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: ae7651c (ae7651caf0169462998355116a349c00c6f4d9c1)
Base parent: 561ea2b (561ea2bfa3022226082e2db39d6ccb241e9e34bc)

@mati865

mati865 commented Sep 7, 2026

Copy link
Copy Markdown
Member Author

Labelling libs because changes like #156743 will no longer be testable on windows-gnu toolchains as they will now utilise the same code path as other Windows targets (gnullvm and msvc).

Upd: T-libs seems to be onboard with this change: https://rust-lang.zulipchat.com/#narrow/channel/219381-t-libs/topic/Enabling.20native.20TLS.20for.20windows-gnu/with/622302693

@mati865 mati865 added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 7, 2026
@mati865
mati865 marked this pull request as ready for review September 7, 2026 19:59
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 7, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 7, 2026
@rustbot

rustbot commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 18 candidates

@rustbot

This comment has been minimized.

@rustbot

rustbot commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

#[thread_local] alignment broken on Windows, GNU ABI Check target definitions to see if more should have cfg(target_thread_local) enabled.

3 participants