windows-gnu: enable native TLS - #159021
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
@bors try jobs=x86_64-mingw,i686-mingw |
This comment has been minimized.
This comment has been minimized.
windows-gnu: enable native TLS try-job: *x86_64-mingw* try-job: *i686-mingw*
|
Labelling libs because changes like #156743 will no longer be testable on windows-gnu toolchains as they will now utilise the same code path as other Windows targets (gnullvm and msvc). Upd: T-libs seems to be onboard with this change: https://rust-lang.zulipchat.com/#narrow/channel/219381-t-libs/topic/Enabling.20native.20TLS.20for.20windows-gnu/with/622302693 |
|
r? @TaKO8Ki rustbot has assigned @TaKO8Ki. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
9c14bee to
f2828cf
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Since Rust 1.98 we have declared minimal supported versions for the tools like the linker. That means native TLS is supposed to work now as seen in try builds in: #156819
Therefore, this change is very likely to cause issues if somebody still doesn't adhere to the requirements. As such I don't know what form of approval will be required.
Fixes #91659
Fixes #135719