Skip to content

cleanup: upstream dropped AMX-TF32 - #159310

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
gmittert:RmAmxTf32
Jul 15, 2026
Merged

cleanup: upstream dropped AMX-TF32#159310
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
gmittert:RmAmxTf32

Conversation

@gmittert

@gmittert gmittert commented Jul 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

LLVM recently dropped x86 AMX-TF32 llvm/llvm-project#207673. This is a re-upload of #158910 as the author is out on vacation for this week.

I've also removed the leftover references to amx-tf32 that were missed in the original PR which caused it to fail the roll up.

r? @durin42

@krasimirgg @gmittert
cleanup: upstream dropped AMX-TF32
1a56799 
Co-authored-by: Gwen Mittertreiner <gmtr@google.com>
@rustbot

rustbot commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in std_detect

cc @Amanieu, @folkertdev, @sayantn

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 14, 2026
@rustbot

rustbot commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @durin42 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@gmittert

gmittert commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

I've listed krasimirgg as the primary author and myself as co-author, is that the expected way to do it or should it be the other way around?

@ilovepi

ilovepi commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

CC: @nikic

@folkertdev

folkertdev commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@bors try jobs=x86_64-gnu-llvm-21-*

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Jul 14, 2026
@bors
Auto merge of #159310 - gmittert:RmAmxTf32, r=<try>
9747d42 
cleanup: upstream dropped AMX-TF32


try-job: x86_64-gnu-llvm-21-*
@rust-bors

rust-bors Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 9747d42 (9747d42e76fc2bcd3c76944ba380074b16320443)
Base parent: da80ed0 (da80ed0708a09dc096c184345d6eb42cbcd50a1e)

@workingjubilee

workingjubilee commented Jul 15, 2026

Copy link
Copy Markdown
Member

I've listed krasimirgg as the primary author and myself as co-author, is that the expected way to do it or should it be the other way around?

seems fine to me!

it looks like this has addressed Nikita's comments and passes so

@bors r=sayantn,workingjubilee

@rust-bors

rust-bors Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 1a56799 has been approved by sayantn,workingjubilee

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2026
@jhpratt jhpratt mentioned this pull request Jul 15, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Jul 15, 2026
@bors
Auto merge of #159316 - jhpratt:rollup-Ap3QBGh, r=jhpratt
47101ad 
Rollup of 15 pull requests

Successful merges:

 - #159311 (Add 1.97.1 release notes)
 - #156220 (Implement `VecDeque::truncate_to_range`)
 - #158608 (Implement `#[diagnostic::opaque]` attribute to hide backtraces of macros.)
 - #159168 (Fix static_mut_refs lint check logic)
 - #159242 (resolve: Inherit eager invocation parents)
 - #159256 (Account for async closures when pointing at lifetime in return type)
 - #159310 (cleanup: upstream dropped AMX-TF32)
 - #158348 (Add documentation for the `inline` attribute)
 - #159181 (add rustc_no_writable to mem::forget and structs it uses)
 - #159191 (Mark `PrivateItems` with `std_internals` unstable feature.)
 - #159194 (rustdoc: Fix auto trait normalization env)
 - #159196 (OnceCell: Improve wording in module docs)
 - #159289 (Fix Zulip backport command suggestion)
 - #159294 (renovate: don't update PRs in the merge queue)
 - #159305 (std: clarify available_parallelism docs for Windows 11 processor groups)
@rust-bors
rust-bors Bot merged commit bd86099 into rust-lang:main Jul 15, 2026
14 checks passed
@rustbot rustbot added this to the 1.99.0 milestone Jul 15, 2026
rust-timer added a commit that referenced this pull request Jul 15, 2026
@rust-timer
Unrolled build for #159310
5755493 
Rollup merge of #159310 - gmittert:RmAmxTf32, r=sayantn,workingjubilee

cleanup: upstream dropped AMX-TF32

LLVM recently dropped x86 AMX-TF32 llvm/llvm-project#207673. This is a re-upload of [#158910](#158910) as the author is out on vacation for this week.

I've also removed the leftover references to amx-tf32 that were missed in the original PR which caused it to fail the roll up.

r? @durin42
@gmittert
gmittert deleted the RmAmxTf32 branch July 15, 2026 14:37
pull Bot pushed a commit to LeeeeeeM/miri that referenced this pull request Jul 16, 2026
@bors
Auto merge of #159316 - jhpratt:rollup-Ap3QBGh, r=jhpratt
c2441c6 
Rollup of 15 pull requests

Successful merges:

 - rust-lang/rust#159311 (Add 1.97.1 release notes)
 - rust-lang/rust#156220 (Implement `VecDeque::truncate_to_range`)
 - rust-lang/rust#158608 (Implement `#[diagnostic::opaque]` attribute to hide backtraces of macros.)
 - rust-lang/rust#159168 (Fix static_mut_refs lint check logic)
 - rust-lang/rust#159242 (resolve: Inherit eager invocation parents)
 - rust-lang/rust#159256 (Account for async closures when pointing at lifetime in return type)
 - rust-lang/rust#159310 (cleanup: upstream dropped AMX-TF32)
 - rust-lang/rust#158348 (Add documentation for the `inline` attribute)
 - rust-lang/rust#159181 (add rustc_no_writable to mem::forget and structs it uses)
 - rust-lang/rust#159191 (Mark `PrivateItems` with `std_internals` unstable feature.)
 - rust-lang/rust#159194 (rustdoc: Fix auto trait normalization env)
 - rust-lang/rust#159196 (OnceCell: Improve wording in module docs)
 - rust-lang/rust#159289 (Fix Zulip backport command suggestion)
 - rust-lang/rust#159294 (renovate: don't update PRs in the merge queue)
 - rust-lang/rust#159305 (std: clarify available_parallelism docs for Windows 11 processor groups)
@nikic nikic mentioned this pull request Jul 16, 2026
Closed
halstead pushed a commit to openembedded/openembedded-core that referenced this pull request Sep 2, 2026
@windsunil @rpurdie
rust: Do not pass the removed x86 amx-tf32 feature to LLVM 23
7b19fd2 
LLVM 23 removed the x86 amx-tf32 subtarget feature, so a rustc built
against LLVM 23 aborts at startup with

  "+amx-tf32" is not a recognized feature for this target

Gate the feature out of to_llvm_features for LLVM >= 23. rust dropped
the feature entirely after 1.98
(rust-lang/rust#159310), but backporting that
would change stable rust behaviour, while a version guard keeps this
rust working against older LLVM majors too.

Signed-off-by: Sunil Dora <sunilkumar.dora@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead pushed a commit to openembedded/openembedded-core that referenced this pull request Sep 2, 2026
@windsunil @rpurdie
rust: Do not pass the removed x86 amx-tf32 feature to LLVM 23
efbe710 
LLVM 23 removed the x86 amx-tf32 subtarget feature, so a rustc built
against LLVM 23 aborts at startup with

  "+amx-tf32" is not a recognized feature for this target

Gate the feature out of to_llvm_features for LLVM >= 23. rust dropped
the feature entirely after 1.98
(rust-lang/rust#159310), but backporting that
would change stable rust behaviour, while a version guard keeps this
rust working against older LLVM majors too.

Signed-off-by: Sunil Dora <sunilkumar.dora@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead pushed a commit to openembedded/openembedded-core that referenced this pull request Sep 3, 2026
@windsunil @rpurdie
rust: Do not pass the removed x86 amx-tf32 feature to LLVM 23
d7e8c32 
LLVM 23 removed the x86 amx-tf32 subtarget feature, so a rustc built
against LLVM 23 aborts at startup with

  "+amx-tf32" is not a recognized feature for this target

Gate the feature out of to_llvm_features for LLVM >= 23. rust dropped
the feature entirely after 1.98
(rust-lang/rust#159310), but backporting that
would change stable rust behaviour, while a version guard keeps this
rust working against older LLVM majors too.

Signed-off-by: Sunil Dora <sunilkumar.dora@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
halstead pushed a commit to openembedded/openembedded-core that referenced this pull request Sep 3, 2026
@windsunil @rpurdie
rust: Do not pass the removed x86 amx-tf32 feature to LLVM 23
9954838 
LLVM 23 removed the x86 amx-tf32 subtarget feature, so a rustc built
against LLVM 23 aborts at startup with

  "+amx-tf32" is not a recognized feature for this target

Gate the feature out of to_llvm_features for LLVM >= 23. rust dropped
the feature entirely after 1.98
(rust-lang/rust#159310), but backporting that
would change stable rust behaviour, while a version guard keeps this
rust working against older LLVM majors too.

Signed-off-by: Sunil Dora <sunilkumar.dora@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sayantn sayantn sayantn approved these changes

Assignees

@workingjubilee workingjubilee

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

8 participants

@gmittert @rustbot @ilovepi @folkertdev @workingjubilee @sayantn @durin42 @krasimirgg