lint ineffective #[unstable] annotations on re-exports by amirHdev · Pull Request #161178 · rust-lang/rust

amirHdev · 2026-08-16T14:49:12Z

rustbot · 2026-08-17T16:53:27Z

rustbot has assigned @mejrs.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 75 candidates
Random selection from 16 candidates

amirHdev · 2026-08-17T16:55:15Z

r? clarfonthey

mejrs

I still need to understand the logic of stability gating better (both what you've added and what's already there), so I'm not done yet

View changes since this review

petrochenkov · 2026-08-19T13:37:43Z

(Also the lint doesn't follow the lint naming conventions - https://rust-lang.github.io/rfcs/0344-conventions-galore.html#lints.)

Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>

mejrs

Thanks for making this happen! And thanks for your patience with all the review cycles :)

@bors r+ rollup

View changes since this review

rust-bors · 2026-09-13T10:19:22Z

📌 Commit 1017887 has been approved by mejrs

It is now in the queue for this repository.

amirHdev · 2026-09-13T10:23:06Z

Thanks for making this happen! And thanks for your patience with all the review cycles :)

Likewise! It was a pleasure working through this with you all

thanks for all the reviews and feedback along the way :)

lint ineffective #[unstable] annotations on re-exports Refs rust-lang#161153 https://rust-lang.zulipchat.com/#narrow/channel/219381-t-libs/topic/stability.20attributes.20on.20imports.20.26.20cargo-semver-checks/with/616818373

Rollup of 5 pull requests Successful merges: - #161178 (lint ineffective #[unstable] annotations on re-exports) - #162642 (Add regression test for matching associated types on new solver) - #162665 (Add a UI regression test.) - #162710 (cg_llvm: Make the LLVM version-check bindings safe) - #162722 (Fix typo in riscv64a23-unknown-linux-gnu platform docs)

JonathanBrouwer · 2026-09-13T14:28:46Z

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #162724 (comment)

rust-bors · 2026-09-13T14:28:52Z

This pull request was unapproved.

This PR was contained in a rollup (#162724), which was unapproved.

View changes since this unapproval

Zalathar · 2026-09-13T14:49:32Z

Ah, I think this is the classic problem where doctests for new lints fail in stage 1, because the bootstrap compiler (beta) doesn’t have those lints.

There’s a trick that needs to be done to skip them when cfg(bootstrap) is set, though I don’t recall the exact syntax needed.

Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>

amirHdev · 2026-09-13T15:48:34Z

@mejrs fixed the stage1 bootstrap doctest failure by ignoring the new-lint example under cfg(bootstrap) while keeping it as a compile_fail example with {{produces}} for non-bootstrap builds

mejrs

@bors r+

View changes since this review

rust-bors · 2026-09-13T16:25:43Z

📌 Commit f5557b0 has been approved by mejrs

It is now in the queue for this repository.

lint ineffective #[unstable] annotations on re-exports Refs rust-lang#161153 https://rust-lang.zulipchat.com/#narrow/channel/219381-t-libs/topic/stability.20attributes.20on.20imports.20.26.20cargo-semver-checks/with/616818373

Rollup of 5 pull requests Successful merges: - #162732 (Fix unsound dealloc of reborrows from custom allocators) - #154113 (std::net: clamp multicast ttl value to u8 max.) - #161178 (lint ineffective #[unstable] annotations on re-exports) - #161612 (std: make a lot of items crate private) - #162717 (prevent ICE from `derive` on `repr(packed)` enum)

Rollup of 6 pull requests Successful merges: - #162706 (Prefer exact derive imports over trait fallbacks) - #162732 (Fix unsound dealloc of reborrows from custom allocators) - #154113 (std::net: clamp multicast ttl value to u8 max.) - #161178 (lint ineffective #[unstable] annotations on re-exports) - #162717 (prevent ICE from `derive` on `repr(packed)` enum) - #162734 (Constify more Iterator and DoubleEndedIterator functions required for Range)

Rollup merge of #161178 - amirHdev:unstable-reexport, r=mejrs lint ineffective #[unstable] annotations on re-exports Refs #161153 https://rust-lang.zulipchat.com/#narrow/channel/219381-t-libs/topic/stability.20attributes.20on.20imports.20.26.20cargo-semver-checks/with/616818373

rust-timer · 2026-09-14T08:38:19Z

Note

This PR was benchmarked as part of triage of its containing rollup: triage URL.

Finished benchmarking commit (ed6bba9): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.3%]	5
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This perf run didn't have relevant results for this metric.

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: missing data
Artifact size: 406.85 MiB -> 406.95 MiB (0.02%)

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 16, 2026

This comment has been minimized.

Sign in to view

amirHdev force-pushed the unstable-reexport branch from 8dd3a1f to 13f91d6 Compare August 16, 2026 14:58

This comment has been minimized.

Sign in to view

amirHdev marked this pull request as ready for review August 17, 2026 16:53

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 17, 2026

rustbot assigned mejrs Aug 17, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 17, 2026

rustbot assigned clarfonthey and unassigned mejrs Aug 17, 2026

mejrs reviewed Aug 18, 2026

View reviewed changes

amirHdev requested a review from mejrs August 18, 2026 14:34

This comment has been minimized.

Sign in to view

amirHdev force-pushed the unstable-reexport branch from c1b5930 to 17f1859 Compare August 18, 2026 15:19

mejrs reviewed Aug 19, 2026

View reviewed changes

Comment thread compiler/rustc_lint_defs/src/builtin.rs

petrochenkov reviewed Aug 19, 2026

View reviewed changes

Comment thread library/alloc/src/io/mod.rs Outdated

amirHdev requested review from mejrs and petrochenkov August 20, 2026 10:47

This comment has been minimized.

Sign in to view

amirHdev added 5 commits August 21, 2026 14:59

lint ineffective #[unstable] annotations on re-exports

79d5626

Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>

handle std fallout from unstable re-export lint

7b7695d

Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>

allow clippy on unstable re-export suppressions

7249fbc

Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>

add dedicated lint for ineffective unstable re-exports

e22c3c2

Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>

refine unstable reexport lint

fbec8a6

Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>

amirHdev force-pushed the unstable-reexport branch from 790a8ab to fbec8a6 Compare August 21, 2026 12:06

mejrs approved these changes Sep 13, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2026

Zalathar mentioned this pull request Sep 13, 2026

Rollup of 3 pull requests #162718

Closed

Zalathar mentioned this pull request Sep 13, 2026

Rollup of 5 pull requests #162724

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 13, 2026

fix bootstrap doctest for ineffective unstable reexports

f5557b0

Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>

mejrs approved these changes Sep 13, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 13, 2026

jhpratt mentioned this pull request Sep 13, 2026

Rollup of 5 pull requests #162737

Closed

jhpratt mentioned this pull request Sep 14, 2026

Rollup of 6 pull requests #162742

Merged

rust-bors Bot merged commit a69f8f9 into rust-lang:main Sep 14, 2026
13 checks passed

rustbot added this to the 1.100.0 milestone Sep 14, 2026

Uh oh!

Uh oh!

Conversation

amirHdev commented Aug 16, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rustbot commented Aug 17, 2026

Uh oh!

amirHdev commented Aug 17, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

mejrs left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

petrochenkov commented Aug 19, 2026

Uh oh!

This comment has been minimized.

mejrs left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Sep 13, 2026

Uh oh!

amirHdev commented Sep 13, 2026

Uh oh!

JonathanBrouwer commented Sep 13, 2026

Uh oh!

rust-bors Bot commented Sep 13, 2026

Uh oh!

Zalathar commented Sep 13, 2026

Uh oh!

amirHdev commented Sep 13, 2026

Uh oh!

mejrs left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Sep 13, 2026

Uh oh!

Uh oh!

rust-timer commented Sep 14, 2026

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

amirHdev commented Aug 16, 2026 •

edited by rustbot

Loading

mejrs left a comment •

edited by rustbot

Loading

mejrs left a comment •

edited by rustbot

Loading

mejrs left a comment •

edited by rustbot

Loading