Normalize non-rigid aliases in ty_known_to_outlive by amirHdev · Pull Request #161246 · rust-lang/rust

amirHdev · 2026-08-17T15:32:49Z

ty_known_to_outlive directly registers a TypeOutlives region obligation without normalization. With the next solver, we do not expect non-rigid aliases in lexical region solving.

Normalize non-rigid aliases before registering the obligation while avoiding trait solving for inputs that do not contain them.

fmease · 2026-08-23T13:50:17Z

r? lcnr

lcnr · 2026-09-07T15:11:05Z

r? adwinwhite I think

adwinwhite · 2026-09-15T07:24:35Z

                    parent_param_env,
                    &wf_tys,
-                    t,
+                    ty::Unnormalized::new_wip(t),


We probably don't want to have trait solving inside liveness analysis.
The types here are actually Params so they don't need normalization.
A quick solution is to have a private ty_known_to_outlive in this module, duplicated from the original impl.
A minimal param outlives evaluator would be good but we need to handle region graph. Then it's no longer minimal :<

As a micro-optimization, we can use resolve_regions_with_outlives_env rather than resolve_regions in this private helper since the wf_tys are the same. This might not matter.

View changes since the review

adwinwhite · 2026-09-15T07:30:25Z

-    })
+    let infcx = tcx.infer_ctxt().build(TypingMode::non_body_analysis());
+
+    let ty = ty.skip_norm_wip();


We only need to skip in the old solver branch.

View changes since the review

adwinwhite · 2026-09-15T07:37:28Z

+    ty: Unnormalized<'tcx, Ty<'tcx>>,
    region: ty::Region<'tcx>,
 ) -> bool {
-    test_region_obligations(tcx, id, param_env, wf_tys, |infcx| {


we can still use test_region_obligations and just normalize the ty?

View changes since the review

yeah that's the part I overlooked 😬 I reused test_region_obligations here

adwinwhite · 2026-09-15T07:42:21Z

Thanks for working on this!

@rustbot author

rustbot · 2026-09-15T07:42:25Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

rustbot · 2026-09-15T10:56:02Z

⚠️ Warning ⚠️

The following commits have merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.
- b7361f8
You can start a rebase with the following commands:
```
$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust.git main
$ git push --force-with-lease
```

lcnr · 2026-09-17T10:28:33Z

@@ -0,0 +1,17 @@
+//@ compile-flags: -Zassumptions-on-binders
+//@ needs-rustc-debug-assertions
+//@ normalize-stderr: "(\n)\n$" -> "$1"


why this?

View changes since the review

this was only normalizing an extra trailing newline in stderr

pls remove, that doesn't feel worth it

ah, sorry, I missed that.

lcnr · 2026-09-17T10:29:10Z

    param_env: ty::ParamEnv<'tcx>,
    wf_tys: &FxIndexSet<Ty<'tcx>>,
-    add_constraints: impl FnOnce(&InferCtxt<'tcx>),
+    add_constraints: impl FnOnce(&InferCtxt<'tcx>) -> bool,


maybe Result<(), ()> instead of bool?

View changes since the review

the bool is only being used to signal normalization failure. I think Result is clearer here

do you want me to update this and cleanup now ?

either now, or in a separate PR. I guess if u fix the ui test, doing it in this PR would be easier

Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>

rust-bors · 2026-09-17T11:39:48Z

⚠️ A new commit c6c7dfd27c2dfcfba28372a3612e5169d61834ee was pushed.

This pull request was unapproved.

This PR was contained in a rollup (#162887), which was closed.

lcnr · 2026-09-17T12:30:50Z

    wf_tys: &FxIndexSet<Ty<'tcx>>,
-    add_constraints: impl FnOnce(&InferCtxt<'tcx>),
+    add_constraints: impl FnOnce(&InferCtxt<'tcx>) -> Result<(), ()>,
 ) -> bool {


don't have to do it in this PR, but you can also return Result here and imo should do so then you can do ?

View changes since the review

amirHdev · 2026-09-18T15:41:54Z

@rustbot ready

lcnr · 2026-09-18T16:07:56Z

@bors r=adwinwhite,lcnr

rust-bors · 2026-09-18T16:07:59Z

📌 Commit c6c7dfd has been approved by adwinwhite,lcnr

It is now in the queue for this repository.

lcnr · 2026-09-18T16:08:01Z

@bors rollup

…s, r=adwinwhite,lcnr Normalize non-rigid aliases in ty_known_to_outlive Fixes rust-lang#161067 `ty_known_to_outlive` directly registers a TypeOutlives region obligation without normalization. With the next solver, we do not expect non-rigid aliases in lexical region solving. Normalize non-rigid aliases before registering the obligation while avoiding trait solving for inputs that do not contain them.

…uwer Rollup of 20 pull requests Successful merges: - #160401 (sparc: make ABI consistent with clang) - #162715 (don't calculate dtors if the self ty has impossible bounds) - #162740 (stdarch subtree update) - #162824 (link Enzyme and the offload with in-tree lld if possible) - #162946 (Simplify query stack printing) - #161005 (fix: unfulfilled nested dead code lint) - #161246 (Normalize non-rigid aliases in ty_known_to_outlive) - #161803 (Fix docs of make_ascii_lowercase/make_ascii_upercase) - #162256 (Add mentions to sync back `RELEASES.md` to the `main` branch) - #162661 (simplify `Target::GenericParam`) - #162666 (Tidy footnote in `platform-support.md`) - #162803 (docs(num): add documentation for `NonZero::from_str`) - #162879 (use u64 limbs in core::num::bignum) - #162903 (PassWrapper: adapt to LLVM reading exception model from module flag) - #162905 (c-variadic: add checks for windows i686) - #162906 (Move more `rustdoc-html` tests in the right location) - #162922 (An assortment of polonius tweaks) - #162929 (Update unicode_data to Unicode version 18.0.0) - #162930 (Use niche length type for strlen to guarantee `isize::MAX` bound) - #162960 (Guard types with unstable `Allocator` params ahead of partial stabilization)

…uwer Rollup of 19 pull requests Successful merges: - #160401 (sparc: make ABI consistent with clang) - #162715 (don't calculate dtors if the self ty has impossible bounds) - #162740 (stdarch subtree update) - #162946 (Simplify query stack printing) - #161005 (fix: unfulfilled nested dead code lint) - #161246 (Normalize non-rigid aliases in ty_known_to_outlive) - #161803 (Fix docs of make_ascii_lowercase/make_ascii_upercase) - #162256 (Add mentions to sync back `RELEASES.md` to the `main` branch) - #162661 (simplify `Target::GenericParam`) - #162666 (Tidy footnote in `platform-support.md`) - #162803 (docs(num): add documentation for `NonZero::from_str`) - #162879 (use u64 limbs in core::num::bignum) - #162903 (PassWrapper: adapt to LLVM reading exception model from module flag) - #162905 (c-variadic: add checks for windows i686) - #162906 (Move more `rustdoc-html` tests in the right location) - #162922 (An assortment of polonius tweaks) - #162929 (Update unicode_data to Unicode version 18.0.0) - #162930 (Use niche length type for strlen to guarantee `isize::MAX` bound) - #162960 (Guard types with unstable `Allocator` params ahead of partial stabilization)

Rollup merge of #161246 - amirHdev:fix-161067-non-rigid-alias, r=adwinwhite,lcnr Normalize non-rigid aliases in ty_known_to_outlive Fixes #161067 `ty_known_to_outlive` directly registers a TypeOutlives region obligation without normalization. With the next solver, we do not expect non-rigid aliases in lexical region solving. Normalize non-rigid aliases before registering the obligation while avoiding trait solving for inputs that do not contain them.

…uwer Rollup of 19 pull requests Successful merges: - rust-lang/rust#160401 (sparc: make ABI consistent with clang) - rust-lang/rust#162715 (don't calculate dtors if the self ty has impossible bounds) - rust-lang/rust#162740 (stdarch subtree update) - rust-lang/rust#162946 (Simplify query stack printing) - rust-lang/rust#161005 (fix: unfulfilled nested dead code lint) - rust-lang/rust#161246 (Normalize non-rigid aliases in ty_known_to_outlive) - rust-lang/rust#161803 (Fix docs of make_ascii_lowercase/make_ascii_upercase) - rust-lang/rust#162256 (Add mentions to sync back `RELEASES.md` to the `main` branch) - rust-lang/rust#162661 (simplify `Target::GenericParam`) - rust-lang/rust#162666 (Tidy footnote in `platform-support.md`) - rust-lang/rust#162803 (docs(num): add documentation for `NonZero::from_str`) - rust-lang/rust#162879 (use u64 limbs in core::num::bignum) - rust-lang/rust#162903 (PassWrapper: adapt to LLVM reading exception model from module flag) - rust-lang/rust#162905 (c-variadic: add checks for windows i686) - rust-lang/rust#162906 (Move more `rustdoc-html` tests in the right location) - rust-lang/rust#162922 (An assortment of polonius tweaks) - rust-lang/rust#162929 (Update unicode_data to Unicode version 18.0.0) - rust-lang/rust#162930 (Use niche length type for strlen to guarantee `isize::MAX` bound) - rust-lang/rust#162960 (Guard types with unstable `Allocator` params ahead of partial stabilization)

amirHdev force-pushed the fix-161067-non-rigid-alias branch 2 times, most recently from 1103014 to b881312 Compare August 18, 2026 07:53

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Aug 18, 2026

This comment has been minimized.

Sign in to view

amirHdev force-pushed the fix-161067-non-rigid-alias branch 3 times, most recently from d0aeadc to 8806add Compare August 20, 2026 10:51

amirHdev changed the title ~~fix: normalize non-rigid aliases in ty_known_to_outlive~~ Normalize non-rigid aliases in ty_known_to_outlive Aug 20, 2026

amirHdev force-pushed the fix-161067-non-rigid-alias branch from 8806add to 52cc388 Compare August 21, 2026 13:55

amirHdev marked this pull request as ready for review August 21, 2026 13:58

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 21, 2026

rustbot assigned dingxiangfei2009 Aug 21, 2026

This comment was marked as outdated.

Sign in to view

rustbot assigned lcnr and unassigned dingxiangfei2009 Aug 23, 2026

rustbot assigned adwinwhite and unassigned lcnr Sep 7, 2026

adwinwhite reviewed Sep 15, 2026

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2026

This comment has been minimized.

Sign in to view

rustbot added the has-merge-commits PR has merge commits, merge with caution. label Sep 15, 2026

amirHdev force-pushed the fix-161067-non-rigid-alias branch from b7361f8 to ed266c7 Compare September 15, 2026 11:05

This comment has been minimized.

Sign in to view

amirHdev force-pushed the fix-161067-non-rigid-alias branch from ed266c7 to 66801ea Compare September 15, 2026 11:15

lcnr reviewed Sep 17, 2026

View reviewed changes

fix: normalize non-rigid aliases in ty_known_to_outlive

c6c7dfd

Signed-off-by: Amirhossein Akhlaghpour <m9.akhlaghpoor@gmail.com>

amirHdev force-pushed the fix-161067-non-rigid-alias branch from 7f7e359 to c6c7dfd Compare September 17, 2026 11:39

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 17, 2026

amirHdev requested a review from lcnr September 17, 2026 11:40

lcnr reviewed Sep 17, 2026

View reviewed changes

amirHdev requested a review from lcnr September 18, 2026 14:08

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 18, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2026

JonathanBrouwer mentioned this pull request Sep 18, 2026

Rollup of 20 pull requests #162980

Closed

JonathanBrouwer mentioned this pull request Sep 18, 2026

Rollup of 20 pull requests #162983

Closed

JonathanBrouwer mentioned this pull request Sep 18, 2026

Rollup of 19 pull requests #162989

Merged

rust-bors Bot merged commit b2bbe14 into rust-lang:main Sep 19, 2026
13 checks passed

rustbot added this to the 1.100.0 milestone Sep 19, 2026

Uh oh!

Conversation

amirHdev commented Aug 17, 2026 • edited by adwinwhite Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment was marked as outdated.

fmease commented Aug 23, 2026

Uh oh!

lcnr commented Sep 7, 2026

Uh oh!

adwinwhite Sep 15, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adwinwhite Sep 15, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

adwinwhite Sep 15, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amirHdev Sep 15, 2026

Choose a reason for hiding this comment

Uh oh!

adwinwhite commented Sep 15, 2026

Uh oh!

rustbot commented Sep 15, 2026

Uh oh!

This comment has been minimized.

rustbot commented Sep 15, 2026

Uh oh!

This comment has been minimized.

lcnr Sep 17, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amirHdev Sep 17, 2026

Choose a reason for hiding this comment

Uh oh!

lcnr Sep 17, 2026

Choose a reason for hiding this comment

Uh oh!

adwinwhite Sep 18, 2026

Choose a reason for hiding this comment

Uh oh!

lcnr Sep 17, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amirHdev Sep 17, 2026

Choose a reason for hiding this comment

Uh oh!

amirHdev Sep 17, 2026

Choose a reason for hiding this comment

Uh oh!

lcnr Sep 17, 2026

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Sep 17, 2026

Uh oh!

lcnr Sep 17, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amirHdev commented Sep 18, 2026

Uh oh!

lcnr commented Sep 18, 2026

Uh oh!

rust-bors Bot commented Sep 18, 2026

Uh oh!

lcnr commented Sep 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

amirHdev commented Aug 17, 2026 •

edited by adwinwhite

Loading

adwinwhite Sep 15, 2026 •

edited by rustbot

Loading

adwinwhite Sep 15, 2026 •

edited by rustbot

Loading

adwinwhite Sep 15, 2026 •

edited by rustbot

Loading

lcnr Sep 17, 2026 •

edited by rustbot

Loading

lcnr Sep 17, 2026 •

edited by rustbot

Loading

lcnr Sep 17, 2026 •

edited by rustbot

Loading