move bug and span_bug macros to rustc_span

[mejrs]

View all comments

This allows them to be used without depending on rustc_middle.

This is done by using a rustc_interface callback so that, if the callback is set, a internal compiler error diagnostic is printed through that. After that the panic is initiated.

r? @jdonszelmann @bjorn3

[rustbot]

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

changes to the core type system

cc @lcnr

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred to constck

cc @fee1-dead

Some changes occurred in coverage instrumentation.

cc @Zalathar

changes to the core type system

cc @lcnr

Some changes occurred in compiler/rustc_codegen_llvm/src/llvm/enzyme_ffi.rs

cc @ZuseZ4

Some changes occurred in compiler/rustc_codegen_llvm/src/builder/autodiff.rs

cc @ZuseZ4

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

Some changes occurred in match checking

cc @Nadrieril

Some changes occurred in match lowering

cc @Nadrieril

rustc_codegen_gcc is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_gcc instead.

cc @antoyo, @GuillaumeGomez

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

HIR ty lowering was modified

cc @fmease

[rustbot]

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

[GuillaumeGomez]

Neat. :)

[rustbot]

rustc_errors::annotate_snippet_emitter_writer was changed

cc @Muscraft

[rustbot]

rustc_codegen_cranelift is developed in its own repository. If possible, consider making this change to rust-lang/rustc_codegen_cranelift instead.

cc @bjorn3

[tiif]

I will only be able to review this on Saturday. If this is bitrotty, feel free to re-roll another reviewer :>

[mejrs]

I will only be able to review this on Saturday. If this is bitrotty, feel free to re-roll another reviewer :>

That's fine, it's best to merge these bitrotty prs during the weekend anyway.

[tiif]

I am slowly reviewing this, a question that came to mind is what is the motivation of moving these macros to rustc_span? Instinctively I think rustc_span is a better place for these macros, but I wonder if there is other reason that I didn't know.

[mejrs]

what is the motivation of moving these macros to rustc_span?

It allows us to use span_bug without needing to depend on rustc_middle, so it will become available in rustc_span itself, parsing, attribute parsing, macro expansion etc. And span_bug is nice because it tells us what the compiler was looking at when it panicked.

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.