Skip to content

Avoid ICEs when recovering malformed function parameters - #162498

Open
TaKO8Ki wants to merge 1 commit into
rust-lang:mainfrom
TaKO8Ki:fix/parser-arg-recovery-ice
Open

TaKO8Ki wants to merge 1 commit into
rust-lang:mainfrom
TaKO8Ki:fix/parser-arg-recovery-ice

Conversation

@TaKO8Ki

@TaKO8Ki TaKO8Ki commented Sep 8, 2026

Copy link
Copy Markdown
Member

Fixes #160337

@rustbot

rustbot commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 8, 2026
@rustbot

rustbot commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 76 candidates
  • Random selection from 20 candidates

@rust-bors

rust-bors Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #162767) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ICE]: entered unreachable code: This method is not called in free functions, as patterns are always allowed there

3 participants