Skip to content

perf: Read initialized dependency reverse indexes directly - #162713

Draft
xmakro wants to merge 1 commit into
rust-lang:mainfrom
xmakro:perf-review-20260907/13-initialized-dep-index
Draft

perf: Read initialized dependency reverse indexes directly#162713
xmakro wants to merge 1 commit into
rust-lang:mainfrom
xmakro:perf-review-20260907/13-initialized-dep-index

Conversation

@xmakro

@xmakro xmakro commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Follow up of #157319

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 13, 2026
@Zalathar

Copy link
Copy Markdown
Member

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 13, 2026
@rust-bors

This comment has been minimized.

rust-bors Bot pushed a commit that referenced this pull request Sep 13, 2026
…p-index, r=<try>

perf: Read initialized dependency reverse indexes directly
@rust-bors

rust-bors Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 0c37179 (0c371795cfa064dbfdd6321537ca4b1a6c0024ff)
Base parent: 67e8d9d (67e8d9d65f33118199f9749343782cc287426587)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (0c37179): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.3% [0.3%, 0.3%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.4% [-0.4%, -0.4%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -0.6%, secondary 1.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.8% [3.6%, 5.8%] 6
Improvements ✅
(primary)
-0.6% [-0.8%, -0.4%] 8
Improvements ✅
(secondary)
-3.8% [-5.5%, -2.3%] 3
All ❌✅ (primary) -0.6% [-0.8%, -0.4%] 8

Cycles

Results (primary 0.3%, secondary -1.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
0.7% [0.4%, 1.0%] 4
Regressions ❌
(secondary)
4.2% [2.5%, 7.5%] 4
Improvements ✅
(primary)
-0.6% [-0.7%, -0.5%] 2
Improvements ✅
(secondary)
-5.8% [-11.2%, -2.4%] 6
All ❌✅ (primary) 0.3% [-0.7%, 1.0%] 6

Binary size

Results (primary -0.0%, secondary -0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.0% [-0.1%, -0.0%] 41
Improvements ✅
(secondary)
-0.1% [-0.1%, -0.0%] 8
All ❌✅ (primary) -0.0% [-0.1%, -0.0%] 41

Bootstrap: 493.573s -> 495.212s (0.33%)
Artifact size: 406.95 MiB -> 406.90 MiB (-0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants