link the offload with in-tree lld if possible by ZuseZ4 · Pull Request #162824 · rust-lang/rust

ZuseZ4 · 2026-09-15T19:57:55Z

I have multiple LLVM builds on all my computers, and often enough ended up with an older lld version on the path, which often breaks Offload builds.
I've also seen autodiff builds take forever since some of it's files are huge, and builds somehow end up using ld.

This fixes both by just using our up-to-date in-tree lld (if available).
I used an LLM to implement a couple of bootstrap fixes, including this one. I then split this one out and cleaned it up.

r? kobzol

closes: #160584

rustbot · 2026-09-15T19:57:58Z

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

rustbot · 2026-09-15T19:58:01Z

kobzol is not on the review rotation at the moment.
They may take a while to respond.

ZuseZ4 · 2026-09-15T20:11:52Z

This should be the last bootstrap PR for a while.
I then (might) just come with a really big one in the future to delete most of this ^^
Now that @sgasho's PR is in, we don't rely on the clang-linker-wrapper anymore and have a bit more control.
The OffloadBinary format was only needed when passing artifacts around between clang tooling, which keeps wrapping and unwrapping IR/asm. Since we're in full control now, we can delete a lot of that.

Kobzol · 2026-09-16T10:06:04Z

+    }
+
+    let lld_bin = builder.ensure(Lld { target }).join("bin");
+    ldflags.push_all(format!("-B{} -fuse-ld=lld", lld_bin.display()));


This duplicates the -fuse-ld=lld flag set on line 846, right?

View changes since the review

Yep. I don't think it's harmful, but I moved it to avoid it.

rustbot · 2026-09-17T04:14:13Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Kobzol · 2026-09-18T07:16:41Z

@bors r+

rust-bors · 2026-09-18T07:16:44Z

📌 Commit 752e7c0 has been approved by Kobzol

It is now in the queue for this repository.

link Enzyme and the offload with in-tree lld if possible I have multiple LLVM builds on all my computers, and often enough ended up with an older lld version on the path, which often breaks Offload builds. I've also seen autodiff builds take forever since some of it's files are huge, and builds somehow end up using ld. This fixes both by just using our up-to-date in-tree lld (if available). I used an LLM to implement a couple of bootstrap fixes, including this one. I then split this one out and cleaned it up. r? kobzol closes: rust-lang#160584

Rollup of 9 pull requests Successful merges: - #161777 (Add Natvis visualiser and debuginfo tests for `f128`) - #162423 (Rename the src install build step to rust-src.) - #162824 (link Enzyme and the offload with in-tree lld if possible) - #161803 (Fix docs of make_ascii_lowercase/make_ascii_upercase) - #162256 (Add mentions to sync back `RELEASES.md` to the `main` branch) - #162803 (docs(num): add documentation for `NonZero::from_str`) - #162906 (Move more `rustdoc-html` tests in the right location) - #162922 (An assortment of polonius tweaks) - #162930 (Use niche length type for strlen to guarantee `isize::MAX` bound)

link Enzyme and the offload with in-tree lld if possible I have multiple LLVM builds on all my computers, and often enough ended up with an older lld version on the path, which often breaks Offload builds. I've also seen autodiff builds take forever since some of it's files are huge, and builds somehow end up using ld. This fixes both by just using our up-to-date in-tree lld (if available). I used an LLM to implement a couple of bootstrap fixes, including this one. I then split this one out and cleaned it up. r? kobzol closes: rust-lang#160584

…uwer Rollup of 15 pull requests Successful merges: - #160401 (sparc: make ABI consistent with clang) - #161777 (Add Natvis visualiser and debuginfo tests for `f128`) - #162423 (Rename the src install build step to rust-src.) - #162740 (stdarch subtree update) - #162824 (link Enzyme and the offload with in-tree lld if possible) - #162832 (add `Div` and `Mul` for `Complex<{float}>`) - #161005 (fix: unfulfilled nested dead code lint) - #161803 (Fix docs of make_ascii_lowercase/make_ascii_upercase) - #162256 (Add mentions to sync back `RELEASES.md` to the `main` branch) - #162661 (simplify `Target::GenericParam`) - #162666 (Tidy footnote in `platform-support.md`) - #162803 (docs(num): add documentation for `NonZero::from_str`) - #162906 (Move more `rustdoc-html` tests in the right location) - #162922 (An assortment of polonius tweaks) - #162930 (Use niche length type for strlen to guarantee `isize::MAX` bound)

link Enzyme and the offload with in-tree lld if possible I have multiple LLVM builds on all my computers, and often enough ended up with an older lld version on the path, which often breaks Offload builds. I've also seen autodiff builds take forever since some of it's files are huge, and builds somehow end up using ld. This fixes both by just using our up-to-date in-tree lld (if available). I used an LLM to implement a couple of bootstrap fixes, including this one. I then split this one out and cleaned it up. r? kobzol closes: rust-lang#160584

…uwer Rollup of 15 pull requests Successful merges: - #160401 (sparc: make ABI consistent with clang) - #161777 (Add Natvis visualiser and debuginfo tests for `f128`) - #162423 (Rename the src install build step to rust-src.) - #162740 (stdarch subtree update) - #162824 (link Enzyme and the offload with in-tree lld if possible) - #161005 (fix: unfulfilled nested dead code lint) - #161803 (Fix docs of make_ascii_lowercase/make_ascii_upercase) - #162256 (Add mentions to sync back `RELEASES.md` to the `main` branch) - #162661 (simplify `Target::GenericParam`) - #162666 (Tidy footnote in `platform-support.md`) - #162803 (docs(num): add documentation for `NonZero::from_str`) - #162906 (Move more `rustdoc-html` tests in the right location) - #162922 (An assortment of polonius tweaks) - #162929 (Update unicode_data to Unicode version 18.0.0) - #162930 (Use niche length type for strlen to guarantee `isize::MAX` bound)

link Enzyme and the offload with in-tree lld if possible I have multiple LLVM builds on all my computers, and often enough ended up with an older lld version on the path, which often breaks Offload builds. I've also seen autodiff builds take forever since some of it's files are huge, and builds somehow end up using ld. This fixes both by just using our up-to-date in-tree lld (if available). I used an LLM to implement a couple of bootstrap fixes, including this one. I then split this one out and cleaned it up. r? kobzol closes: rust-lang#160584

…uwer Rollup of 14 pull requests Successful merges: - #160401 (sparc: make ABI consistent with clang) - #161777 (Add Natvis visualiser and debuginfo tests for `f128`) - #162740 (stdarch subtree update) - #162824 (link Enzyme and the offload with in-tree lld if possible) - #161005 (fix: unfulfilled nested dead code lint) - #161803 (Fix docs of make_ascii_lowercase/make_ascii_upercase) - #162256 (Add mentions to sync back `RELEASES.md` to the `main` branch) - #162661 (simplify `Target::GenericParam`) - #162666 (Tidy footnote in `platform-support.md`) - #162803 (docs(num): add documentation for `NonZero::from_str`) - #162906 (Move more `rustdoc-html` tests in the right location) - #162922 (An assortment of polonius tweaks) - #162929 (Update unicode_data to Unicode version 18.0.0) - #162930 (Use niche length type for strlen to guarantee `isize::MAX` bound)

link Enzyme and the offload with in-tree lld if possible I have multiple LLVM builds on all my computers, and often enough ended up with an older lld version on the path, which often breaks Offload builds. I've also seen autodiff builds take forever since some of it's files are huge, and builds somehow end up using ld. This fixes both by just using our up-to-date in-tree lld (if available). I used an LLM to implement a couple of bootstrap fixes, including this one. I then split this one out and cleaned it up. r? kobzol closes: rust-lang#160584

…uwer Rollup of 20 pull requests Successful merges: - #160401 (sparc: make ABI consistent with clang) - #162715 (don't calculate dtors if the self ty has impossible bounds) - #162740 (stdarch subtree update) - #162824 (link Enzyme and the offload with in-tree lld if possible) - #162946 (Simplify query stack printing) - #161005 (fix: unfulfilled nested dead code lint) - #161246 (Normalize non-rigid aliases in ty_known_to_outlive) - #161803 (Fix docs of make_ascii_lowercase/make_ascii_upercase) - #162256 (Add mentions to sync back `RELEASES.md` to the `main` branch) - #162661 (simplify `Target::GenericParam`) - #162666 (Tidy footnote in `platform-support.md`) - #162803 (docs(num): add documentation for `NonZero::from_str`) - #162879 (use u64 limbs in core::num::bignum) - #162903 (PassWrapper: adapt to LLVM reading exception model from module flag) - #162905 (c-variadic: add checks for windows i686) - #162906 (Move more `rustdoc-html` tests in the right location) - #162922 (An assortment of polonius tweaks) - #162929 (Update unicode_data to Unicode version 18.0.0) - #162930 (Use niche length type for strlen to guarantee `isize::MAX` bound) - #162960 (Guard types with unstable `Allocator` params ahead of partial stabilization)

JonathanBrouwer · 2026-09-18T21:04:18Z

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #162983 (comment)

rust-bors · 2026-09-18T21:04:26Z

This pull request was unapproved.

This PR was contained in a rollup (#162983), which was unapproved.

View changes since this unapproval

JonathanBrouwer · 2026-09-18T21:04:44Z

@bors try jobs=dist-x86_64-llvm-mingw

link Enzyme and the offload with in-tree lld if possible try-job: dist-x86_64-llvm-mingw

ZuseZ4 · 2026-09-18T21:17:22Z

Oh, this was aimed at and tested on x86-linux, since that's where offload is currently active, but I guess via autodiff it could have broken mingw, even though I'd find it a bit surprising. I'll have a look, sorry

rust-bors · 2026-09-18T23:17:26Z

💔 Test for f70d840 failed: CI. Failed job:

try - dist-x86_64-llvm-mingw (web logs, enhanced plaintext logs)

…built

ZuseZ4 · 2026-09-22T19:04:49Z

Enzyme only gets a bootstrap time improvement, whereas the offload side needs this improvement to build on some targets. Since Enzyme failed on mingw, I limited it to offload which only runs on linux for now.
@bors try jobs=dist-x86_64-linux

link the offload with in-tree lld if possible try-job: dist-x86_64-linux

rust-bors · 2026-09-22T20:52:03Z

☀️ Try build successful (CI)
Build commit: d721131 (d72113161dd4274d0b068443252f231e2683ed83)
Base parent: b794652 (b794652dc70d72efc28970704c9ebe04d59fea5d)

ZuseZ4 · 2026-09-22T20:58:54Z

@bors r=Kobzol rollup

rust-bors · 2026-09-22T20:58:58Z

📌 Commit d296cf2 has been approved by Kobzol

It is now in the queue for this repository.

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 15, 2026

rustbot assigned Kobzol Sep 15, 2026

ZuseZ4 mentioned this pull request Sep 15, 2026

Tracking Issue for GPU-offload #131513

Open

5 tasks

Kobzol reviewed Sep 16, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

ZuseZ4 force-pushed the use-lld-more branch 2 times, most recently from 7f7e355 to 752e7c0 Compare September 17, 2026 04:14

Kobzol approved these changes Sep 18, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2026

Zalathar mentioned this pull request Sep 18, 2026

Rollup of 9 pull requests #162941

Closed

JonathanBrouwer mentioned this pull request Sep 18, 2026

Rollup of 11 pull requests #162943

Closed

JonathanBrouwer mentioned this pull request Sep 18, 2026

Rollup of 15 pull requests #162951

Closed

JonathanBrouwer mentioned this pull request Sep 18, 2026

Rollup of 15 pull requests #162954

Closed

JonathanBrouwer mentioned this pull request Sep 18, 2026

Rollup of 14 pull requests #162973

Closed

JonathanBrouwer mentioned this pull request Sep 18, 2026

Rollup of 20 pull requests #162980

Closed

JonathanBrouwer mentioned this pull request Sep 18, 2026

Rollup of 20 pull requests #162983

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 18, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Sep 18, 2026

Auto merge of #162824 - ZuseZ4:use-lld-more, r=<try>

f70d840

link Enzyme and the offload with in-tree lld if possible try-job: dist-x86_64-llvm-mingw

This comment has been minimized.

Sign in to view

bootstrap: link the offload runtimes with the in-tree lld when it is …

d296cf2

…built

ZuseZ4 force-pushed the use-lld-more branch from 752e7c0 to d296cf2 Compare September 22, 2026 19:02

ZuseZ4 changed the title ~~link Enzyme and the offload with in-tree lld if possible~~ link the offload with in-tree lld if possible Sep 22, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Sep 22, 2026

Auto merge of #162824 - ZuseZ4:use-lld-more, r=<try>

d721131

link the offload with in-tree lld if possible try-job: dist-x86_64-linux

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 22, 2026

Uh oh!

Conversation

ZuseZ4 commented Sep 15, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Sep 15, 2026

Uh oh!

rustbot commented Sep 15, 2026

Uh oh!

ZuseZ4 commented Sep 15, 2026

Uh oh!

Uh oh!

Kobzol Sep 16, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ZuseZ4 Sep 17, 2026

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

rustbot commented Sep 17, 2026

Uh oh!

Kobzol commented Sep 18, 2026

Uh oh!

rust-bors Bot commented Sep 18, 2026

Uh oh!

JonathanBrouwer commented Sep 18, 2026

Uh oh!

rust-bors Bot commented Sep 18, 2026

Uh oh!

JonathanBrouwer commented Sep 18, 2026

Uh oh!

This comment has been minimized.

ZuseZ4 commented Sep 18, 2026

Uh oh!

rust-bors Bot commented Sep 18, 2026

Uh oh!

This comment has been minimized.

ZuseZ4 commented Sep 22, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Sep 22, 2026

Uh oh!

ZuseZ4 commented Sep 22, 2026

Uh oh!

rust-bors Bot commented Sep 22, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ZuseZ4 commented Sep 15, 2026 •

edited by rustbot

Loading

Kobzol Sep 16, 2026 •

edited by rustbot

Loading