Add setgroups to std::os::unix::process::CommandExt

[slo1]

Should fix #38527. I'm not sure groups is the greatest name though.

[rust-highfive]

r? @shepmaster

(rust_highfive has picked a reviewer for you, use r? to override)

[shepmaster]

As this appears to add public API (perhaps insta-stable), I'm gonna tag in...

r? @joshtriplett

[joshtriplett]

Needs some changes; with those made, I'd be happy to re-review.

[joshtriplett]

On May 23, 2020 3:31:23 AM PDT, Jake Goulding ***@***.***> wrote: @shepmaster commented on this pull request.> > > > > @@ -81,6 +81,7 @@ pub struct Command {> gid: Option<gid_t>,> saw_nul: bool,> closures: Vec<Box<dyn FnMut() -> io::Result<()> + Send + Sync>>,> + groups: Option<Vec<gid_t>>,> > So there’s a difference between calling `.groups(vec![])` and never calling it to start with?>

Yes. setgroups with null or an empty list clears all supplementary gids. Not calling setgroups at all leaves the current set of supplementary gids.

[slo1]

Sorry for the delay. I made the requested changes

[JohnCSimon]

ping from triage:
@slo1 can you mark the change requested by joshtriplett as completed?

[slo1]

ping from triage:
@slo1 can you mark the change requested by joshtriplett as completed?

@JohnCSimon How do I do that? I think I already marked all the conversations as resolved.

[slo1]

@joshtriplett Could you take a look at my changes? Maybe it would have been better to put another commit on top of my previous one, instead of squashing them together.

[bors]

☔ The latest upstream changes (presumably #73265) made this pull request unmergeable. Please resolve the merge conflicts.

[KodrAus]

@bors r+

[bors]

📌 Commit de36aa0ed350f7ff6c1df156dd8023cd7f026e7c has been approved by KodrAus

[bors]

⌛ Testing commit de36aa0ed350f7ff6c1df156dd8023cd7f026e7c with merge 31502a228a70000f735f1cfd9a517037686deba5...

[rust-log-analyzer]

The job dist-various-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

error: unused variable: `g`
   --> library/std/src/sys/unix/process/process_unix.rs:186:25
    |
186 |             if let Some(g) = self.get_groups() {
    |                         ^ help: if this is intentional, prefix it with an underscore: `_g`
    |
    = note: `-D unused-variables` implied by `-D warnings`
error: aborting due to previous error; 1 warning emitted

[RUSTC-TIMING] std test:false 3.207
error: could not compile `std`
error: could not compile `std`

To learn more, run the command again with --verbose.
command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-redox" "-Zbinary-dep-depinfo" "-j" "16" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/library/test/Cargo.toml" "--message-format" "json-render-diagnostics"
failed to run: /checkout/obj/build/bootstrap/debug/bootstrap dist --host= --target asmjs-unknown-emscripten,wasm32-unknown-emscripten,x86_64-rumprun-netbsd,mips-unknown-linux-musl,mipsel-unknown-linux-musl,mips64-unknown-linux-muslabi64,mips64el-unknown-linux-muslabi64,arm-unknown-linux-musleabi,arm-unknown-linux-musleabihf,armv5te-unknown-linux-gnueabi,armv5te-unknown-linux-musleabi,armv7-unknown-linux-musleabihf,aarch64-unknown-none,aarch64-unknown-none-softfloat,sparc64-unknown-linux-gnu,x86_64-unknown-redox,thumbv6m-none-eabi,thumbv7m-none-eabi,thumbv7em-none-eabi,thumbv7em-none-eabihf,thumbv8m.base-none-eabi,thumbv8m.main-none-eabi,thumbv8m.main-none-eabihf,riscv32i-unknown-none-elf,riscv32imc-unknown-none-elf,riscv32imac-unknown-none-elf,riscv64imac-unknown-none-elf,riscv64gc-unknown-none-elf,armebv7r-none-eabi,armebv7r-none-eabihf,armv7r-none-eabi,armv7r-none-eabihf,thumbv7neon-unknown-linux-gnueabihf,armv7a-none-eabi
Build completed unsuccessfully in 0:19:11

[bors]

💔 Test failed - checks-actions

[slo1]

The job dist-various-1 failed! Check out the build log: (web) (plain)
Click to see the possible cause of the failure (guessed by this bot)

Do I just change g to _g to cover the redox case? I feel that is an awkward fix.

[KodrAus]

@bors r+

[bors]

📌 Commit a4db851 has been approved by KodrAus

[bors]

⌛ Testing commit a4db851 with merge 22ddcd1...

[bors]

☀️ Test successful - checks-actions
Approved by: KodrAus
Pushing 22ddcd1 to master...