Improve symbol normalization in binary_stats#1931
Merged
Kobzol merged 2 commits intorust-lang:masterfrom Aug 12, 2024
Merged
Conversation
lqd
reviewed
Aug 11, 2024
Member
lqd
left a comment
lqd
left a comment
There was a problem hiding this comment.
(Oooops I didn't see this, sorry.)
I'm not sure we can be fully accurate and without conflating symbols to be perfect in all cases. Depending on the tasks, sometimes in the past I've had to compare using mangled symbols because the monomorphizations were important, e.g. when using const generics.
Here we're best effort so these are improvements to me.
Kobzol
force-pushed
the
binary-stats-improve
branch
from
4fc3e48 to
87347af
Compare
lqd
reviewed
Aug 11, 2024
lqd
approved these changes
Aug 11, 2024
Member
lqd
left a comment
lqd
left a comment
There was a problem hiding this comment.
one last typo fix.
and if we don't want to do anything yet about the pre-demangling dot because of the other issue, then we should be good
Kobzol
force-pushed
the
binary-stats-improve
branch
from
e0ab36a to
c1216b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few improvements and tests added when I was investigating rust-lang/rust#126965 (comment).