refactor(install): simplify InstallMethod methods, pt. 3 - #5086
Merged
Merged
Conversation
djc
approved these changes
Sep 16, 2026
Contributor
|
Good stuff! Still wondering if we can improve on the need to deref-then-clone some kinds of toolchain names, which looks pretty ugly to my eyes. |
Member
Author
@djc I tried, but that would involve the introduction of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of rust-lang/goals#736; continuation of #5083.
Specifically, this patch hopes to address the concern raised by @djc in #5083 (comment).