You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@Cloud0310 What is the rationale of this PR? As I see it, it doesn't always remove the implicit dependency on process.cargo_home(), because functions like do_remove_from_path() still rely on it?
Here, the purpose is for later allowing passing down the actual bin path for clean up later in future PR. But as for do_remove_path the final view is kinda different from others. It's also carrying the duty of resolving home and the location of legacy rc files via shell::legacy_paths(process).
So this part isn't included as this would require further modification.
@Cloud0310 I see. In that case I think it'd be beneficial to resolve all data dependencies upfront, rather than passing both process and cargo_home which might be a bit confusing because I have the feeling that the latter subsumes the former. You can do this in a subsequent PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse cargo home resolution result in APIs.
Part of #5056.