Skip to content

x86: remove "unsafe" from tests that do not need it #1981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Amanieu merged 1 commit into from
Dec 31, 2025
Merged

x86: remove "unsafe" from tests that do not need it #1981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/core_arch/src/x86/abm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,12 @@ mod tests {
use crate::core_arch::x86::*;

#[simd_test(enable = "lzcnt")]
const unsafe fn test_lzcnt_u32() {
const fn test_lzcnt_u32() {
assert_eq!(_lzcnt_u32(0b0101_1010), 25);
}

#[simd_test(enable = "popcnt")]
const unsafe fn test_popcnt32() {
const fn test_popcnt32() {
assert_eq!(_popcnt32(0b0101_1010), 4);
}
}
12 changes: 6 additions & 6 deletions crates/core_arch/src/x86/aes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ mod tests {
use crate::core_arch::x86::*;

#[simd_test(enable = "aes")]
unsafe fn test_mm_aesdec_si128() {
fn test_mm_aesdec_si128() {
// Constants taken from https://msdn.microsoft.com/en-us/library/cc664949.aspx.
let a = _mm_set_epi64x(0x0123456789abcdef, 0x8899aabbccddeeff);
let k = _mm_set_epi64x(0x1133557799bbddff, 0x0022446688aaccee);
Expand All @@ -122,7 +122,7 @@ mod tests {
}

#[simd_test(enable = "aes")]
unsafe fn test_mm_aesdeclast_si128() {
fn test_mm_aesdeclast_si128() {
// Constants taken from https://msdn.microsoft.com/en-us/library/cc714178.aspx.
let a = _mm_set_epi64x(0x0123456789abcdef, 0x8899aabbccddeeff);
let k = _mm_set_epi64x(0x1133557799bbddff, 0x0022446688aaccee);
Expand All @@ -132,7 +132,7 @@ mod tests {
}

#[simd_test(enable = "aes")]
unsafe fn test_mm_aesenc_si128() {
fn test_mm_aesenc_si128() {
// Constants taken from https://msdn.microsoft.com/en-us/library/cc664810.aspx.
let a = _mm_set_epi64x(0x0123456789abcdef, 0x8899aabbccddeeff);
let k = _mm_set_epi64x(0x1133557799bbddff, 0x0022446688aaccee);
Expand All @@ -142,7 +142,7 @@ mod tests {
}

#[simd_test(enable = "aes")]
unsafe fn test_mm_aesenclast_si128() {
fn test_mm_aesenclast_si128() {
// Constants taken from https://msdn.microsoft.com/en-us/library/cc714136.aspx.
let a = _mm_set_epi64x(0x0123456789abcdef, 0x8899aabbccddeeff);
let k = _mm_set_epi64x(0x1133557799bbddff, 0x0022446688aaccee);
Expand All @@ -152,7 +152,7 @@ mod tests {
}

#[simd_test(enable = "aes")]
unsafe fn test_mm_aesimc_si128() {
fn test_mm_aesimc_si128() {
// Constants taken from https://msdn.microsoft.com/en-us/library/cc714195.aspx.
let a = _mm_set_epi64x(0x0123456789abcdef, 0x8899aabbccddeeff);
let e = _mm_set_epi64x(0xc66c82284ee40aa0, 0x6633441122770055);
Expand All @@ -161,7 +161,7 @@ mod tests {
}

#[simd_test(enable = "aes")]
unsafe fn test_mm_aeskeygenassist_si128() {
fn test_mm_aeskeygenassist_si128() {
// Constants taken from https://msdn.microsoft.com/en-us/library/cc714138.aspx.
let a = _mm_set_epi64x(0x0123456789abcdef, 0x8899aabbccddeeff);
let e = _mm_set_epi64x(0x857c266b7c266e85, 0xeac4eea9c4eeacea);
Expand Down
Loading