Use a generic type to implement SIMD types in core_arch::simd and avoid unsafe fn in more tests
#1987
+1,658
−1,296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
eduardosm
commented
Jan 1, 2026
Comment on lines
+138
to
+153
|
|
||
| $(#[$stability])+ | ||
| impl crate::convert::From<crate::core_arch::simd::Simd<$elem_type, $len>> for $name { | ||
| #[inline(always)] | ||
| fn from(simd: crate::core_arch::simd::Simd<$elem_type, $len>) -> Self { | ||
| unsafe { crate::mem::transmute(simd) } | ||
| } | ||
| } | ||
|
|
||
| $(#[$stability])+ | ||
| impl crate::convert::From<$name> for crate::core_arch::simd::Simd<$elem_type, $len> { | ||
| #[inline(always)] | ||
| fn from(simd: $name) -> Self { | ||
| unsafe { crate::mem::transmute(simd) } | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This is now easy to include thanks to the generic core_arch::simd::Simd type.
eduardosm
commented
Jan 1, 2026
Comment on lines
+83
to
+89
| // `#[derive(Clone)]` causes ICE "Projecting into SIMD type core_arch::simd::Simd is banned by MCP#838" | ||
| impl<T: SimdElement, const N: usize> Clone for Simd<T, N> { | ||
| #[inline] | ||
| fn clone(&self) -> Self { | ||
| *self | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I don't know why the ICE with #[derive(Clone)] did not happen with non-generic types.
eduardosm
force-pushed
the
generic-simd-type-avoid-unsafe-tests
branch
from
5c7b4fc to
3ddd60e
Compare
This allows the `types` macro to easily implement `From<Simd<T, N>>` and `Into<Simd<T, N>>`
eduardosm
force-pushed
the
generic-simd-type-avoid-unsafe-tests
branch
5 times, most recently
from
e08cdf5 to
c6fa637
Compare
eduardosm
commented
Jan 1, 2026
Comment on lines
-5552
to
+5804
| test_vcombine!(test_vcombine_f16 => vcombine_f16([3_f16, 4., 5., 6.], | ||
| [13_f16, 14., 15., 16.])); | ||
| #[cfg_attr(target_arch = "arm", simd_test(enable = "neon,fp16"))] | ||
| #[cfg_attr(not(target_arch = "arm"), simd_test(enable = "neon"))] | ||
| fn test_vcombine_f16() { | ||
| let a = f16x4::from_array([3_f16, 4., 5., 6.]); | ||
| let b = f16x4::from_array([13_f16, 14., 15., 16.]); | ||
| let e = f16x8::from_array([3_f16, 4., 5., 6., 13_f16, 14., 15., 16.]); | ||
| let c = f16x8::from(vcombine_f16(a.into(), b.into())); | ||
| assert_eq!(c, e); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
No longer uses the test_vcombine due to the need of specifying "fp16" depending on ARM version.
eduardosm
force-pushed
the
generic-simd-type-avoid-unsafe-tests
branch
from
c6fa637 to
f51739a
Compare
eduardosm
force-pushed
the
generic-simd-type-avoid-unsafe-tests
branch
from
f51739a to
ccfe133
Compare
eduardosm
commented
Jan 1, 2026
| ;; | ||
| armv7-*eabihf | thumbv7-*eabihf) | ||
| export RUSTFLAGS="${RUSTFLAGS} -Ctarget-feature=+neon" | ||
| export RUSTFLAGS="${RUSTFLAGS} -Ctarget-feature=+neon,+fp16" |
Contributor
Author
There was a problem hiding this comment.
Since fp16 cannot be checked at runtime (at least is_arm_feature_detected does not support it), we enable it at compile time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.