Skip to content

Handle case where community review threshold was reached before reopen - #2496

Merged
Urgau merged 3 commits into
rust-lang:mainfrom
Urgau:assign-community-review-reopened-2
Aug 29, 2026
Merged

Urgau merged 3 commits into
rust-lang:mainfrom
Urgau:assign-community-review-reopened-2

Conversation

@Urgau

@Urgau Urgau commented Aug 29, 2026

Copy link
Copy Markdown
Member

Follow-up to #2494 meant to address #2494 (comment).

Let's just check if the threshold for minimum community reviews had already been reached before and only if not re-add the "monitoring" label.

@Urgau
Urgau requested a review from Kobzol August 29, 2026 11:54
Comment thread src/handlers/assign.rs
Comment thread src/handlers/assign.rs
@Kobzol
Kobzol added this pull request to the merge queue Aug 29, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 29, 2026
@Urgau

Urgau commented Aug 29, 2026

Copy link
Copy Markdown
Member Author

Weird, a docker failure. Let's hope it's just spurious.

Details

#26 ERROR: error writing layer blob: not_found
------
 > exporting to GitHub Actions Cache:
------

 1 warning found (use docker --debug to expand):
 - JSONArgsRecommended: JSON arguments recommended for CMD to prevent unintended behavior related to OS signals (line 57)
ERROR: failed to build: failed to solve: error writing layer blob: not_found

@Urgau
Urgau added this pull request to the merge queue Aug 29, 2026
Merged via the queue into rust-lang:main with commit 32ce419 Aug 29, 2026
4 checks passed
@Urgau
Urgau deleted the assign-community-review-reopened-2 branch August 29, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants