Upgrade to rand v0.10 and/or v0.9, and split rand_core#338
Upgrade to rand v0.10 and/or v0.9, and split rand_core#338cuviper wants to merge 3 commits intorust-num:masterfrom
rand v0.10 and/or v0.9, and split rand_core#338Conversation
This now implements `RandBigInt` with only `rand_core::Rng` to allow a slimmer dependency tree. The other distribution-related types still require `rand` for its traits though. Our `gen_big*` methods are also renamed to `random_big*` to match the change that `rand` had made in 0.9. The old names are deprecated, but still present, simply forwarding to the new names.
Cargo.toml
Outdated
| [dependencies.rand] | ||
| optional = true | ||
| version = "0.8" | ||
| version = "0.10.0-rc.9" |
There was a problem hiding this comment.
I'll wait in draft until 0.10.0 is released.
|
0.10 is out! looks good to me, i copied your homework to debug my fork rand 0.10 update guide if this is a minor release i'd hate to see a major one |
|
@xtqqczze Just for MSRV, can't you keep using the current rand support? As I see it, 0.9 would only be useful if you also need interoperability with other crates using the same rand. However, I'm also considering that maybe we should support both -- e.g. use |
Yes, releasing with |
rand v0.10 and split rand_core v0.10rand v0.10 and/or v0.9, and split rand_core
This wasn't too hard to manage -- please take a look! |
This now implements
RandBigIntwith onlyrand_core::Rngto allow aslimmer dependency tree. The other distribution-related types still
require
randfor its traits though.Our
gen_big*methods are also renamed torandom_big*to match thechange that
randhad made in 0.9. The old names are deprecated, butstill present, simply forwarding to the new names.
Hat tip to @bionicles and @divergentdave as well for their
rand v0.9PRs (#317, #322),and I apologize for never getting around to those. Let's reset that debt by getting
0.10 much sooner!
The crate features are now explicitly versioned, allowing either 0.9 or 0.10, or both.
So we now have
rand_0_9,rand_core_0_9,rand_0_10, andrand_core_0_10.RandBigIntis also renamed and forked toBigRng09andBigRng010, so the nameis versioned and better implies that it is an extension of
Rng. The other distributionstructs are simply shared with trait implementations for either/both versions.